Where did handleAuthorizeRequest go? about yii2-oauth2-server

[ebuzzz]

I'm back to using this library, and the current documentation mismatches the code. The README shows that you should create an authorize action in the SiteController. But the Module.php no longer contains the handleAuthorizeRequest method. It was removed in the commit mentioned above.

I believe the method should be added back, or the README should be changed to contain the correct code (by implementing the code that was previously in the Module.php)

    /**
     * @return mixed
     */
    public function actionAuthorize()
    {
        if (Yii::$app->getUser()->getIsGuest())
            return $this->redirect('login');

        /** @var $module \filsh\yii2\oauth2server\Module */
        $module = Yii::$app->getModule('oauth2');
        $response = $module->handleAuthorizeRequest(!Yii::$app->getUser()->getIsGuest(), Yii::$app->getUser()->getId());

        /** @var object $response \OAuth2\Response */
        Yii::$app->getResponse()->format = \yii\web\Response::FORMAT_JSON;

        return $response->getParameters();
    }

[mtangoo]

Did something stop working?

[ebuzzz]

I don't know, because I didn't use the method yet :) But commit d8c3aba removed the handleAuthorizeRequest method, and I can't see a reason why:

[mtangoo]

can you please test and see if it works as its supposed to?

[ebuzzz]

It's just something I noticed when reading the documentation. I switched to a different module, so I won't be using this code in production.

[SmirnovMaxim]

I'm back to using this library, and the current documentation mismatches the code. The README shows that you should create an authorize action in the SiteController. But the Module.php no longer contains the handleAuthorizeRequest method. It was removed in the commit mentioned above.

I believe the method should be added back, or the README should be changed to contain the correct code (by implementing the code that was previously in the Module.php)

You must change this code to the code below

public function actionAuthorize()
{
        if (Yii::$app->getUser()->getIsGuest())
            return $this->redirect('login');

        /** @var $server filsh\yii2\oauth2server\Server */
        $server = Yii::$app->getModule('oauth2')->getServer();
        $response = $server->handleAuthorizeRequest(null, null, true, Yii::$app->getUser()->getId());

        /** @var object $response \OAuth2\Response */
        Yii::$app->getResponse()->format = \yii\web\Response::FORMAT_JSON;

        return $response->getParameters();
}

[varp]

@eborned Could you check if the problem still exist in the latest release v2.1.0?

[varp]

Feel free to re-open. Closing due to inactivity.