Comments (7)
I created #446. Also, please comment there if you know any other shortcuts that are commonly used in PWAs and conflict with built-in Firefox options (apart from ones already on the list).
from pwasforfirefox.
I see there is a ac5032f but maybe make the default behavior in-sync with the Chromium one, to not confuse the users?
from pwasforfirefox.
But if Ctrl+W
is disabled by default, that may confuse Firefox users who expect it to close the tab (and the window if it's the only tab)...
from pwasforfirefox.
Well, as it's an "application" now it's more expected it would want to handle such combination itself.
Also, I think it's still better to keep this behavior consistent between different PWA vendors, as casual user shouldn't care much which vendor provides the PWA but just expects consistent behavior of the app itself.
My 2 cents.
from pwasforfirefox.
Yeah, but I still think it's better to have the same shortcuts as normal Firefox. In any case, disabling the shortcut takes just a few clicks if you need it disabled. So, I'll close this issue.
Another possibility is to keep the shortcut normally enabled, but allow the website to overwrite it. I think this is what Edge (and probably Chromium) does. I may add another option for this (which may be enabled by default) in the future, but I cannot guarantee when, as first I want to clean up and improve some existing code.
from pwasforfirefox.
I may add another option for this
Let's make task/issue for that to track?
from pwasforfirefox.
Ok, I will create it soon.
from pwasforfirefox.
Related Issues (20)
- Linux aarch64 Support for Runtime installer? HOT 2
- Error: "can't access property "href", e is null" HOT 2
- Allow user to edit the name of the PWA when installing HOT 5
- Changing the default links target option HOT 4
- Winget option not working properly. HOT 7
- Fix launching without `JOB_OBJECT_LIMIT_BREAKAWAY_OK` permission HOT 9
- How do I use these environment variables? HOT 1
- Add an option to open app to previous state HOT 2
- Closing Firefox causes PWA to crash HOT 7
- All PWA windows open as a Blank window HOT 7
- Failed to uninstall firefoxpwa runtime HOT 2
- CORS whitelist option HOT 2
- Corners are not rounded, inner site overlaps. HOT 4
- Scrolling at lower FPS on 120hz Screen. macOS Sonoma. HOT 1
- Web apps broken in Firefox 124 HOT 19
- Can't pin PWA apps to taskbar after update HOT 2
- False positive malware detection by Microsoft Defender HOT 3
- Crunchyroll doesn't work with manifest enabled HOT 3
- macOS task switchers always show the Firefox icon HOT 2
- Allowed Domains: Support Wildcard/Regex HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pwasforfirefox.