Comments (8)
If breaking changes in upstream is a problem, we can go with a versioned branch in go module dependency.
[[constraint]]
branch = "v27"
name = "gopkg.in/libgit2/git2go.v27"
I have a version that works with go module. But it is little lagging behind.
https://github.com/jsixface/gitql/tree/git2go
from gitql.
I looked into the possibility of making a static build, but that is kind of impossible since libigt2 has dependencies.
Note that even if libgit2 is included in the resulting binary, its dependencies will not be.
https://github.com/libgit2/git2go#master-branch-or-static-linking
The best I can think of is, to setup go module, include a versioned branch of git2go in go dependency and have libgit2, openSSL and LibSSH2 as separately installed dependency.
from gitql.
Thanks for the research @jsixface . That's something that I don't know exactly how to solve keeping libgit2 as dependecny 😿.
If you if find anything else please send it for us here.
from gitql.
Hey @navigaid , first of all thanks a lot for the effort.
When gitql was cretead we didn't have go modules so the best way to make sure that git2go would not break the compiling was to fork it and point to cloudson/git2go
. If you think that we need to upgrade cloudson/git2go, we can do that.
Can you make a pull request with your gitql changes and the git2go upgrade?
from gitql.
The problem of use github.com/libgit2/git2go
without go modules is that they can upgrade the
lib breaking compatibility (it already happened before). That's why I'm in favor to keep cloudson/git2go until go modules support.
So, for me, we could merge your changes of gitql + static compilation pointing to an upgraded cloudson/git2go.
After that we can move to go modules and remove cloudson/git2go. The intent is to have baby steps and smaller changes. What do you think?
from gitql.
@jsixface we have now static binaries for windows and linux so I'm going to close this. For macos it something that we need to improve but we also need to track if most of the users use mac and require this.
from gitql.
What is the issue with static binary for MacOS. I can give it a try.
from gitql.
When I tried throught github actions, it happened something like this
https://stackoverflow.com/questions/3801011/ld-library-not-found-for-lcrt0-o-on-osx-10-6-with-gcc-clang-static-flag
from gitql.
Related Issues (20)
- Error on parsing
- Use default $GOPATH if it's not set
- owner in remotes table HOT 4
- feature request:publish windows build binary HOT 3
- Functional tests
- Bug: select * from remotes fails HOT 1
- Feature idea: Include more nice badges on top of README? HOT 1
- Improve code coverage HOT 1
- "Show databases" feature
- "Use" feature
- Error when using `distinct` HOT 3
- Set Up Dependabot HOT 4
- Bug: Application panics on query with double quotes HOT 6
- Refactor: Change visibility of methods, structs and variables HOT 5
- Bug: Git stash entries listed as commits HOT 3
- Bug: Functional tests do not run on windows VM HOT 2
- Refactor: Make a literal/constant tokens map HOT 2
- Benchmarks
- Is count supported? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitql.