Version 0.5.0 breaks the nice Ctrl+C interrupt about filewatcher

[thomasfl]

Thanks for your feedback and screencast. The last pull-request was the biggest so far, and I clearly didn't test filewatcher enough. The spinner was my idea, but should clearly be optional. It interfers with output from stdout. I have to have a look at it tomorrow.

[thomasfl]

There is a new version 0.51 available from now on github that exists silently on sigint. I haven't pushed the gem yet, but please install it from the repo and tell me what you think:

    git clone https://github.com/thomasfl/filewatcher.git
    cd filewatcher
    gem build filewatcher.gemspec
    gem install filewatcher-0.5.1.gem

The spinner is now optional via the --spinner option.

BTW! Have you tried the --restart option? It speeds up autotesting so much that I have concidered making it default. It makes filewatcher fork a new process that the shell commands run in, and instead of waiting for the command to finish on file system updates, it starts up a new process and kills the old process in the background.

[DannyBen]

Excellent. Will test a little later and report back.
(Havent tested --restart yet).

EDIT:

Ok - built and installed 0.5.1, and both the repro case and my actual use case seem to work fine (same as 0.4.0) - no spinner by default, and sigint is handled properly.

I also think it is a good call to make the spinner off by default (and may I suggest perhaps to change it to "Watching" instead of "Scanning").

I tried the --restart option, but did not notice anything different. Maybe my use case is too simple.
If you want me to take a deeper look, let me know what to look for.

[thomasfl]

Thanks for your feedback Danny!

I'll change the text from "scanning" to "watching".

The speed increase with the --restart option is noticeable on my laptop. A better name for the option would be --background, because it runs the shell command in the background in a separate fork. If you use filewatcher for autotesting, and saves a source file several times with short interval between each time, then you'll notice the difference.

[DannyBen]

I see.

I will try that feature in my day to day use.

Since this feature is also doing some process forking trickery, I would be cautious about making it the default operation. Maybe let it be like it is now for a while, see if people report problems, and then decide if it should be the default or not in one of the future major releases.

[thomasfl]

I've changed the text displayed next to the scanner from "scanning" to "watching" and pushed the new 0.5.1 to the rubygems.org repository.

Thanks again for taking the time to test filewatcher.

[DannyBen]

My pleasure, thanks for the quick fix.