Coder Social home page Coder Social logo

Comments (4)

fhchl avatar fhchl commented on June 11, 2024

Hi Sebastian,

It's a great idea to merge the two packages and I would happily add you as a maintainer to this package. I am not sure, though, if my approach is the best way. The three most obvious ways seem to be using the linter package, the spell-checker package or doing it by hand. At the time, the latter seemed to be the only way to be able to choose from multiple suggestions, toggle LT checking off/on anytime and display some info on the spelling error. Also, I liked to hack a bit and learn about Markers etc. ...

Now, it seems that version 2 of the linter package has some functionality to choose between multiple suggestions, if I interpret the solutions attribute in the Message v2 API correctly. This could be a much smarter way, as we would not have to hassle around with the display of errors. v2 also allows for enabling and disabling specific linters at will.

One of us should try this out. What do you think?

Best,
Franz

from languagetool.

wysiib avatar wysiib commented on June 11, 2024

I think we should avoid brewing our own solution and connect via the linter package or the spell-checker one. Hopefully maintenance overhead will be reduced that way?

In the next few days I will try to update my package to the linter v2 api. As I see it, we can either port your code for extraction of suggestions, etc. to my package or we can port your package to the linter api.

Do you know anything about the spellcheck api? I've never used it so I cannot judge if its a better way to proceed.

from languagetool.

fhchl avatar fhchl commented on June 11, 2024

Yes, lets connect to the linter v2 and see how that works. The problem with spell-checker was that you can not easily display the LT error messages along the suggestions. I find that information very useful. (At least I didn't figure out how to do it). Turning LT corrections on and off is also only possible by enabling/disabling the LT package, whereas I think we can specify the scopes in which the LT linter will be active (is that actually true?)

from languagetool.

wysiib avatar wysiib commented on June 11, 2024

I was able to connect to linterv2. however, the tests do not run through at the moment. Scopes can be specified using the linter. I will add you to the repository in a moment and push the linter v2 version even though tests are not running atm.

from languagetool.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.