Coder Social home page Coder Social logo

Comments (6)

FGRibreau avatar FGRibreau commented on August 16, 2024

Hello @valeriansaliou,

Thanks for the report!
I tested it and it worked even without any david:{} configuration object.
Do you have check-build last version? 1.7.1 ?

To verify:

node -e "console.log(require('`npm bin -g`/../lib/node_modules/check-build/package.json').version);"

from check-build.

valeriansaliou avatar valeriansaliou commented on August 16, 2024

Yep, 1.7.1 is being used.

~  node -e "console.log(require('`npm bin -g`/../lib/node_modules/check-build/package.json').version);"
1.7.1

Though, I'm not using check-build from global context but rather from local (package) context.
It is defined as a devDependency as:

"devDependencies": {
  "check-build": "^1.7.1"
}

Nothing wrong, I assume. Still open to more testings on my side, if you have suggestions ;)

Thanks!

from check-build.

FGRibreau avatar FGRibreau commented on August 16, 2024

hum, I don't see what could go wrong... I added some debug in v2.0.0 and refactored a little the internals.

npm install check-build@latest -S && DEBUG=* `npm bin`/check-build

What's the output of the david section?

from check-build.

valeriansaliou avatar valeriansaliou commented on August 16, 2024

@FGRibreau okay, got some more insight for you there: https://infinit.io/_/7h9eWGe

When I execute david separately from its bare binary file, it "succeeds" at failing on outdated deps.
The debug logs from check-build may not be enough though.

from check-build.

valeriansaliou avatar valeriansaliou commented on August 16, 2024

Oh crap! Got it.

Looks like your default configuration doesn't check for devDependencies by default, although david binary defaults does.

Got a proper return w/ the following david options in .checkbuild:

{
  "david": {"dev":true,"stable":true,"ignore":[]}
}

Anyway, should be specified in the README or anywhere else, can submit a MR if you'd like.

from check-build.

FGRibreau avatar FGRibreau commented on August 16, 2024

Fixed in cf04943, closing :)

from check-build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.