Coder Social home page Coder Social logo

Comments (4)

polyvertex avatar polyvertex commented on May 21, 2024

How so? os.path is as Windows-compatible as it can be.

However I noticed improper file path manipulation in project's code, tests included. Typically path.split("/") or os.path.join(somedir, "foo/bar/")...

from workoutizer.

fgebhart avatar fgebhart commented on May 21, 2024

You are of course right, os.path is totally windows compatible.

When I wrote this issue, I simply added a windows-latest to the matrix test and realized a bunch of tests were failing because of improper paths.

I thought it would be good to streamline the usage of path handling methods to just use either of both options and since I preferred pathlib I came up with this issue.

Your approach seems also to be totally valid 👍

from workoutizer.

polyvertex avatar polyvertex commented on May 21, 2024

I simply added a windows-latest to the matrix test and realized a bunch of tests were failing because of improper paths.

Path manipulations that were fixed in #209 is a step towards workoutizer's Windows compat I guess 😀

I thought it would be good to streamline the usage of path handling methods to just use either of both options and since I preferred pathlib I came up with this issue.

pathlib is appealing but its use might be overkill in some places. Typically when only a call to os.path.basename would do for instance. So that you do not need to instantiate a PurePath object (or derived) for a single path manipulation.

from workoutizer.

fgebhart avatar fgebhart commented on May 21, 2024

Closing this issue, since the original intend was to resolve improper path manipulation which blocked the windows compatibility. See #210 for ongoing migrations efforts.

from workoutizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.