Comments (4)
How so? os.path
is as Windows-compatible as it can be.
However I noticed improper file path manipulation in project's code, tests included. Typically path.split("/")
or os.path.join(somedir, "foo/bar/")
...
from workoutizer.
You are of course right, os.path
is totally windows compatible.
When I wrote this issue, I simply added a windows-latest
to the matrix test and realized a bunch of tests were failing because of improper paths.
I thought it would be good to streamline the usage of path handling methods to just use either of both options and since I preferred pathlib
I came up with this issue.
Your approach seems also to be totally valid 👍
from workoutizer.
I simply added a windows-latest to the matrix test and realized a bunch of tests were failing because of improper paths.
Path manipulations that were fixed in #209 is a step towards workoutizer's Windows compat I guess 😀
I thought it would be good to streamline the usage of path handling methods to just use either of both options and since I preferred pathlib I came up with this issue.
pathlib
is appealing but its use might be overkill in some places. Typically when only a call to os.path.basename
would do for instance. So that you do not need to instantiate a PurePath
object (or derived) for a single path manipulation.
from workoutizer.
Closing this issue, since the original intend was to resolve improper path manipulation which blocked the windows compatibility. See #210 for ongoing migrations efforts.
from workoutizer.
Related Issues (20)
- Make the auto-import more flexible HOT 15
- ENH: Provide feedback on progress of "Reimport" in UI
- Introduce mypy to code base
- Introduce isort to code base HOT 1
- [BUG] run_docker.sh does not forward container port HOT 3
- [BUG] Readme in setup dir does not install latest version of workoutizer HOT 5
- [BUG] processing demo activity's does not complete HOT 7
- [ENH] Officially support Python 3.7 and run on Raspberry Pi (ARM) HOT 3
- [BUG] 920xt not mounting automatically HOT 9
- TST: Test results not consistent
- [BUG] Incorrect if statement causes block devices to never be mounted
- [BUG] Altitude is shown incorrectly HOT 6
- [BUG] Block device not settled yet when mount triggerd by wkz_mount.service HOT 7
- [ENH] Make workoutizer Windows compatible
- [BUG] macos build pipeline seems broken
- [BUG] Rounding errors cause wkz.gis.geo distance calculation error. HOT 4
- Trouble getting workoutizer to work HOT 13
- Make path to activities inside garmin device configurable
- Add import/copy command to workoutizer HOT 2
- BUG: Error in filter when e.g. avg_speed is not available in fit file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from workoutizer.