Coder Social home page Coder Social logo

Comments (6)

fffonion avatar fffonion commented on May 24, 2024

Hi @kajmagnus, yes you can definitely use the lua-resty-http in __index method since it's called inside a timer.

Adding a callback hook is a good syntax sugar feature, for now I guess you can get pretty much the same by just putting it into __index. Similarly you can also get the storage backend using require("resty.acme.autossl").storage.

from lua-resty-acme.

kajmagnus avatar kajmagnus commented on May 24, 2024

@fffonion ok thanks, sounds good.

(Personally I'm guessing people would be fine with __index, if there was just some docs mentioning that one can call Redis, or the app server, from __index, and sample code about how to use it. I could reply here with some sample code, if I implement such an __index function in the future — maybe in two or three months. )

A timer — that's Kong's lua-resty-timer, I'm guessing (?), i.e. extra timer functionality based on https://github.com/openresty/lua-nginx-module#ngxtimerat .

from lua-resty-acme.

fffonion avatar fffonion commented on May 24, 2024

Yeah i'll add a note in the readme on that.

Actually I made a mistake here, checking domain in the whitelist in run in the ssl_certificate_by context. But you can still use cosocket API i.e. doing network operations.

from lua-resty-acme.

kajmagnus avatar kajmagnus commented on May 24, 2024

@fffonion Wow that was fast :- )

From the new docs:

Do note that this will increase the SSL handshake latency

Is that for each connection, always, or just the very first connection when the HTTPS cert doesn't yet exist, and gets created?

from lua-resty-acme.

fffonion avatar fffonion commented on May 24, 2024

It's for each connection, always. Since we rely on that whitelist to decide "whether i'm going to serve certificate (or order a new one) for this domain".

But you can make it smarter by adding some cache for example.

from lua-resty-acme.

fffonion avatar fffonion commented on May 24, 2024

This is implemented as domain_whitelist_callback and will be available in next release : )

from lua-resty-acme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.