Coder Social home page Coder Social logo

Is the version unambiguous? about spec HOT 4 OPEN

fernet avatar fernet commented on August 30, 2024
Is the version unambiguous?

from spec.

Comments (4)

chadwhitacre avatar chadwhitacre commented on August 30, 2024

From a skim of the 16 commits, here are the ones that jump out as potentially version-bumping changes:

ca8b345 pins to CBC, meaning that implementations of 1fa950a's 0x80 don't guarantee CBC.

58d2827 appears to change from nanoseconds to seconds—the commit message ("new format") and diff (wait—"gAAAAA" is new?! 😳 ) in 115850d further suggest a version-bump-worthy change.

3bbe466 "document checking version byte"—so it is new

c55d0d4 diff suggests that base64url was indicated in at least some specific locations in the original 0x80—was it so indicated everywhere?

0514d7d clear algorithm change

was it so indicated everywhere?

0250c59 Answer: no.

from spec.

chadwhitacre avatar chadwhitacre commented on August 30, 2024

Is the version unambiguous?

The answer appears to be "yes."

In which case, the action item here is to ... what? Clean up Fernet's versioning somehow. By applying new version numbers to the version-bumping commits above? By dropping back to Git SHA for version? By adopting semantic versioning?

from spec.

chadwhitacre avatar chadwhitacre commented on August 30, 2024

To be explicit: this issues makes auditing somewhat more difficult.

from spec.

chadwhitacre avatar chadwhitacre commented on August 30, 2024

Clean up Fernet's versioning somehow.

By tagging 0250c59 as 0x80 and adopting a versioning policy for future changes?

from spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.