Comments (8)
(not you Kate. just the unfeeling cosmos in general)
from spin.
Confirmed finalisers do not appear to run.
from spin.
@itowlson I was able to repro this. With a neverends
plugin:
#!/bin/bash
i=0
while true; do
echo $i
i=$(( i+1 ))
sleep .5
done
Interestingly adding kill_on_drop(true)
did resolve it for me. Stopping the spin (cargo run
) process also killed the plugin process
let mut command = Command::new(binary);
command.args(args);
command.envs(get_env_vars_map()?);
command.kill_on_drop(true);
from spin.
Oh interesting! How did you stop the Spin process? In my case the parent process is kill_on_drop
-ing the Spin process so maybe your way of stopping is giving it a chance to clean up okay. Thanks!
from spin.
I had to add a Ctrl+C handler to external
- that seemed to work but more cruft sigh
from spin.
I cannot repro my success with my changes, so I agree that kill_on_drop
does not work. Will also keep trying!
from spin.
AHHH THE CTRL+C HANDLER WORKED AND NOW IT DOESN'T
CURSE YOU ALL
from spin.
oh SOMETIMES it works
from spin.
Related Issues (20)
- Record OTel metrics in host components
- OTel features overwhelmed during high load HOT 5
- Build failed (aedc2b8ccc65f41615fa7beb3e427843dd782114) HOT 3
- Spin 2.6 release HOT 11
- Spin apps are no longer allowed to set host headers with Wasmtime 21.0.1 HOT 6
- Enable mustache-inspired string templates for `key_value_stores` and others HOT 6
- Add version control support to `spin new` or spin CLI HOT 12
- Rust and Python traces with KV store are not showing all KV spans in the same trace
- Remove HTTP trigger `base` option
- Consider deprioritizing the environment variable provider HOT 6
- Add `spin up --trigger-type` flag
- Enable pushing components with `spin registry push` HOT 3
- `spin login` keeps asking for one-time code after authorizaton HOT 6
- `spin --tree` or `spin --list` providing a tree structure of available subcommands and flags in spin cli HOT 3
- hello-python not working HOT 12
- Added flexibility to Spin allowed outbound hosts
- inconsistencies when making outbound http requests HOT 1
- Custom trigger with other WASI worlds requires trait implementation for `spin_core::Data<T>` HOT 2
- Add an S3 key/value storage provider interface HOT 3
- SQLITE error after update from 2.5.1 to 2.6.0 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spin.