Comments (10)
Released as v2.2.3
Thanks for your issue!
BTW: I handled the mergeHapiLogData
in this release as well.
from laabr.
Hey Andrew (@stout01), thanks for your request.
First of all options.hapiPino.mergeHapiLogData
does not work currently. It's disabled internally because the token :message
needs the data nested in the message
property of the logged message. If that's an additionally need, just push another issue or in best case a PR :)
Next: is it possible that I take a look on your project?
I'm really wondering because all those scenarios are captured with unit tests.
Additionally I added temporarily the line laabr.format('response', '>> :cid <<');
to examples/correlator.js
:
Works for me.
from laabr.
I created a quick example app where I am still having the issue.
https://github.com/stout01/HapiLoggingExample
from laabr.
What's your npm/node version? And what's your OS?
from laabr.
Windows 7
node: v8.1.1
npm: v5.3.0
from laabr.
Installed node v8.1.1 & npm v5.3.0: works on macOS like a charm.
do you work w/ windows?
from laabr.
My work machine is windows 7...
Maybe I'm missing something, but your screen shot only shows the header once. The way I have the format line setup, it should show the x-request-id
header twice in the log statement.
from laabr.
Nope, it shows the correlation id stored in the continuation-local-storage.
The dash in the middle is the request header field x-request-id
. This is just truthy if you send a respective header:
But yeah, you are right. There something wrong when using curl.
When using cocoa it works o.O It's necessary to send an additional accept-encoding
header with the value/s gzip
and/or deflate
. Don't know why, gonna investigate.
@stout01 I asked some of the hapi core devs for help...I'm not really familiar with the compression logic in hapi. If there's no reply until tomorrow, I'll publish a hotfix.
from laabr.
There's a release branch (https://github.com/felixheck/laabr/tree/release/2.2.3) containing the hotfix. would be nice if you could test it again in your environment but it should work :)
I'll release it just after I get the feedback.
from laabr.
Perfect. Its working as expected now. Thanks for being so on top of it!
from laabr.
Related Issues (20)
- logQueryParams is not allowed HOT 3
- security vulnerability
- Redact option is not usable HOT 2
- Default value "-" used on all falsy values instead of null / undefined HOT 3
- Log call without tags shows - HOT 2
- Update to Pino/Hapi-Pino v5 HOT 1
- WIP: hapi v18 support
- Adding pre from request object HOT 6
- Response header fields not logged
- Missing console.debug binding
- TypeError: Converting circular structure to JSON HOT 1
- Unable to specify pino options HOT 2
- Missing output of console.error when using override: true HOT 1
- No colors in Docker container, even if colored is true - solved HOT 1
- URL no longer appearing in log output in version 6+
- Problems when logging on AWS CloudWatch HOT 3
- joi as a peer dependency HOT 3
- how to use laabr directly on another file? HOT 2
- How to apply custom format with color? HOT 2
- Is it possible to limit the payload tag? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laabr.