Full screen does not work properly from sidebar about tw5-tiddlymap

[tobibeer]

Sidebars are for table of contents and some side information, not for holding an editor

I think, especially for "diving mode", the sidebar is a perfect place.

Not sure, but I think you can always create a TiddlyMap tiddler that transcludes the sidebar tab. Done.

[danielo515]

Dear @tobibeer

Not sure, but I think you can always create a TiddlyMap tiddler that transcludes the sidebar tab. Done

Do you really think the average user will do this? You have created many customizations that makes other trivial task easier. This is easy for us, not for everyone. In fact, is even uncomfortable for me, because I have to remember how to do this on every new TW

[felixhayashi]

Hi guys,

I think, especially for "diving mode", the sidebar is a perfect place.

What tobi says here is what I think too, the sidebar is perfect because it is fixed and no matter how far you scroll down, you can always see the connections on the right. I am developing a plugin at the moment that will trigger the "diving" (seeing neighbors) automatically when a tiddler is scrolled to. Also for drag'n'drop it is the right place. Moreover, the editor is not really part of the content like tiddlers are.

In fact, is even uncomfortable for me, because I have to remember how to do this on every new TW

The problem is, I have to make a decision where to put the main editor and for the reasons mentioned, I really think the sidebar is the suitable place. Having two places for the main editor will confuse users.

But Danielo, it is really easy to create an editor in a tiddler. Just add

<tiddlymap height="400px" editor="advanced"></tiddlymap>

to a tiddler of your choice (without view="..."). Done.

The screen is filled just half. See screenshot below from chrome on windows

This is really strange. It works fine in firefox 34 and chrome 39... Which browser are you using? Could you open the browser console then open the editor in fullscreen and post the debug log please?

-Felix

[tobibeer]

What Danielo posted is the same thing I was referring to: #21 (comment)

@danielo515, wait a a tiny moment for some documentation to appear... then, using that $tiddlymap widget should be an easy thing to do... if not frequent in terms of embedding a special view in a tiddler, etc... perhaps even wrapped in a macro simplifying things yet more.

[danielo515]

This is all I get

@MAIN_EDITOR Toggle fullscreen
$:/plugins/felixhayashi/tiddlymap/caretaker.js:21 @MAIN_EDITOR Adding fullscreen markers
$:/plugins/felixhayashi/tiddlymap/caretaker.js:21 @MAIN_EDITOR Repainting the whole graph
$:/plugins/felixhayashi/tiddlymap/caretaker.js:21 @MAIN_EDITOR Toggle fullscreen

pretty normal I think. My chrome version is Version 39.0.2171.95 m on windows 7.

In firefox it works nicely. Strange

[felixhayashi]

Thanks @danielo515,

The log really seems fine. I changed some css now. could you please test it again?

http://felixhayashi.github.io/TW5-TiddlyMap/index.html (0.6.4+904)

-Felix

[tobibeer]

@felixhayashi, I don't get the problematic behavior anymore. Fullscreen now seems to work properly in both sidebar and story.

[felixhayashi]

nice thanks for telling me tobi

[andtheWings]

I'm getting the full-screen bug too when I press full-screen from side-bar in Chrome 40 on Windows 7. Nothing really on the console:

@MAIN_EDITOR Toggle fullscreen
@MAIN_EDITOR Adding fullscreen markers
@MAIN_EDITOR Repainting the whole graph
@MAIN_EDITOR Removing fullscreen markers
@MAIN_EDITOR Repainting the whole graph

[felixhayashi]

Hi @andtheWings,

I'm getting the full-screen bug too when I press full-screen from side-bar in Chrome 40 on Windows 7.

Thanks for telling me and posting the debug. Could you tell me exactly what doesn't work or post a screenshot?

[tobibeer]

Seems to be back for me as well... but I get a different log.

These tiddlers changed: Object {$:/temp/focussedTiddler: Object}
@MAIN_EDITOR Toggle fullscreen
@MAIN_EDITOR Adding fullscreen markers
@MAIN_EDITOR Repainting the whole graph
These tiddlers changed: Object {$:/temp/focussedTiddler: Object}

[felixhayashi]

Ok I will check that. Maybe this is because I added the tmap- prefix for all the classes lately. This is what I was afraid of (stuff crashes after this change) 😱

[tobibeer]

perhaps, should be easy to find then

[felixhayashi]

yesss crazy bug. Turns out: Media queries on smaller screens override my css "left" value. I couldn't find the bug as my screen is large (>960px). also it only happens on chrome in combination with windows. How on earth should a programmer troubleshoot that??

[felixhayashi]

should work now ;)
edit this time for real!

[danielo515]

Ok. It works now for me. Thank you very much!

[tobibeer]

dito, works as expected... thanks a lot for fixing

[felixhayashi]

Thanks guys, then I will close this now! Finally!