Comments (12)
For the problem I mentionned before, problem solved . Just change theses cases :
case "Add2" :
note2 = note1+2;
note3 = note1+4;
note4 = note1+7;
break;
case "Addm2" :
note2 = note1+1;
note3 = note1+4;
note4 = note1+7;
break;
case "Addm3" :
note2 = note1+3;
note3 = note1+4;
note4 = note1+7;
break;
from piano.
Uhmmmm
Maybe you can create a triggers to simulate click on keys...
from piano.
i am thinking to make chords programatically, do you think that is possible??
from piano.
I think yes.
But I don't have imagined it when I've created this project.
from piano.
By the momento firing click does not work:
$($("li.key")[1]).click();
I suppose that to fire the event that plays the sound will be enough
from piano.
The correct approach is
$("li.key:nth-child(2) > .black-key").trigger('click');
or $("li.key:nth-child(2) > .white-key").trigger('click');
from piano.
that sounds on you machine???
from piano.
Not, it's weird.
I need to test again later.
from piano.
Hello from France :)
You think about making chords, like this ? http://www.pianochord.org/
I would be very interested to. And I would be interested to contribute to it.
The other day, I just made a simple keyboard on my Codepen, but it isn't as good as yours.
from piano.
Hi @aureliet. This is an old project (since 2013), but I want to update it.
I like any suggestion to improve piano and I am open to PR's accepts 😹
Thanks!
from piano.
Hello @lfeh !
My code can be better, I think, but now we can have the chords.
Can I propose the app to a music school?
They won't pay me for it. Maybe one free piano lesson but that's all. They would be interested to use it on their website for their students.
Edit :
in the index.html :
Now we have data-number on the spans. From this, we can calculate the chords.
And we have two selects, to get the different chords variations.
in the _general.js :
The js I added to make chords
And... we will have to add notes, because from the A# to the end, we don't have enough...
from piano.
Hey @developez, check if it works now?
from piano.
Related Issues (14)
- Icons Font HOT 4
- Add option for save and share song HOT 1
- Update the code of project
- Improve README
- Is it possible to make this piano functional on mobile devices? HOT 13
- Feedback [my impressions of the piano] HOT 1
- Add possibility to play more than one key on piano HOT 8
- Logo Design HOT 15
- Hello sir, I'm a graphic designer HOT 2
- (macOS) Caps lock key only detected when turned on HOT 1
- Stop etmek HOT 4
- 同学,您这个项目引入了923个开源组件,存在12个漏洞,辛苦升级一下 HOT 2
- Issue downloading dependencies
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from piano.