Comments (10)
Hi @JohannesKlauss, thanks for the feedback.
The reason the mapEventToState
signature is (S state, E event)
is because the state parameter is referring to the current state rather than the new state.
In onTransition
as well as the Bloc
class type signature the state is referring to the next state (the output of the Bloc
).
Also, mapEventToState
is inspired by Redux Reducers whose function signature is (S previousState, A action)
.
A Bloc
is described as converting Events
to States
(<E, S>
) ; however, mapEventToState
takes the current state and event and returns the new state (S currentState, E event)
.
Thoughts? Does that help clarify why it's written the way it is?
from bloc.
Wait. If state is the current state, then it makes sense because it exists before the event does. I really need to study this function
from bloc.
It would be very clear if the variable was named currentState or oldState, etc
from bloc.
haha yeah I will rename it and add the documentation for the generic types
from bloc.
@JohannesKlauss closing this for now.
Feel free to respond with any comments or concerns and I'll gladly reopen the issue.
from bloc.
OK, came to report this as well. It was confusing. Can you add in the docs what the generic types are for? I figured them out, but not after digging.
Like It's not clear what E is, and what S is until later down the code
from bloc.
@ThinkDigitalRepair sure I can definitely update the docs. Do you think it makes sense otherwise or do you still feel strongly that it doesn't make sense as is?
from bloc.
from bloc.
Yes I agree that generally input is coming from the left side but the way I view it is in this case we have two inputs and we're creating a new state object. The two inputs are S currentState and E event. I personally thought it made sense in that order because the currentState precedes the event. Thoughts?
from bloc.
changes included in bloc v0.7.4
from bloc.
Related Issues (20)
- docs: I need help understanding Bloc-to-Bloc Communication HOT 2
- feat(evented_bloc): A new package for Blocs and Cubits with the ability to fire events... HOT 1
- discussion: Implementing Dynamic Bloc Switching HOT 4
- ReplayBloc function onTransition() handles event _Undo instead of user defined event HOT 2
- fix: In Flutter v3.16.4 stable the fromJson method stopped working HOT 1
- Flutter Bloc With Alert Dialogs throws an error HOT 4
- why my code will result in error? HOT 2
- BlocBuilder not getting called after creating new task, ListView still displays old data HOT 2
- question: bloc with many datasets HOT 26
- feat: Use with Freezed HOT 1
- BlocBuilder only build once and stop rebuild with subsequent emit HOT 6
- fix: hydrated bloc stopped persisting state after update (^9.1.3) HOT 6
- Cannot override EventHandler (Bug?) HOT 1
- fix: The "New Bloc/Cubit" option is not showing in VSCode Extensions HOT 2
- feate
- feat: why not fusion bloc_concurrency package into bloc HOT 2
- feat: BlocListener that trigger once but with return specific prop like BlocSelector HOT 3
- Help: Flutter Bloc Test: Unexpected State Change After Multiple Events HOT 6
- Help:add a event but state not change HOT 3
- TabBarView bug with Scrollable.ensureVisible and bloc HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bloc.