Incorrect price for NOE games that have multiple editions? about nintendeals

[nemecek-filip]

Finally had some time to look into this and it seems like the price is correct. The issue is that the import logic that iterates over the games selected the NSUIDs for the more expensive editions.

[fedecalendino]

Hi!

Would you mind showing me how can I reproduce this with the library?

[nemecek-filip]

Sure, I am not 100% sure however that my description of the issue is correct.

I am using the iterator noe.list_switch_games() to import games into my system. The "Atelier Ryza 3: Alchemist of the End & the Secret Key" (https://www.nintendo.co.uk/Games/Nintendo-Switch-games/Atelier-Ryza-3-Alchemist-of-the-End-the-Secret-Key-2265346.html) has 3 editions on the NOE Store, however I got imported only once with the name "
Atelier Ryza 3: Alchemist of the End & the Secret Key" and NSUID: 70070000016453

When I call the prices API with my local currenty and this id, I get ('70070000016453', CZK 2749.0) which is the highest possible price and corresponds to the price of the Ultimate Edition.

This issue is quite rare I think as I haven't run into it frequently.

I guess the expected behavior would either be to have all the three editions imported or to have just the one but with NSUID that correponds to the cheapest edition of this game.

[nemecek-filip]

I have also tried just now to use the search API:

        for game in noe.search_switch_games(query="Atelier Ryza 3: Alchemist of the End & the Secret Key"):
            print(game.title, "/", game.nsuid)

But this lists whole bunch of games without single Atelier Ryza 3.

[fedecalendino]

Hi again! Just pushed a fix for this on v3.1.1.

from nintendeals import noe

for game in noe.list_switch_games():
    if "Atelier Ryza" in game.title:
        print(game.title, game.nsuid)

Atelier Ryza 2: Lost Legends & the Secret Fairy 70070000011310
Atelier Ryza 2: Lost Legends & the Secret Fairy 70010000030968
Atelier Ryza 2: Lost Legends & the Secret Fairy 70070000011311
Atelier Ryza 3: Alchemist of the End & the Secret Key 70070000016453
Atelier Ryza 3: Alchemist of the End & the Secret Key 70070000016452
Atelier Ryza 3: Alchemist of the End & the Secret Key 70010000054893
Atelier Ryza: Ever Darkness and the Secret Hideout 70010000021547

About the search I'm not sure why is not working, because when I search for Atelier Ryza it finds the following games:

Atelier Sophie 2: The Alchemist of the Mysterious Dream 70070000013562 HACYA25GF
Atelier Sophie 2: The Alchemist of the Mysterious Dream 70070000013561 HACYA25GE
Atelier Sophie 2: The Alchemist of the Mysterious Dream 70010000041947 None
Atelier Ryza 2: Lost Legends & the Secret Fairy 70070000011310 HACYAYASK
Atelier Ryza 2: Lost Legends & the Secret Fairy 70010000030968 HACPAYASB
Atelier Ryza 2: Lost Legends & the Secret Fairy 70070000011311 HACYAYASL
Atelier Ryza 3: Alchemist of the End & the Secret Key 70070000016453 HACYA899E
Atelier Ryza 3: Alchemist of the End & the Secret Key 70070000016452 HACYA899D
Atelier Ryza 3: Alchemist of the End & the Secret Key 70010000054893 HACMA899B
Atelier Totori ~The Adventurer of Arland~ DX 70010000014711 HACPAQYUB
Atelier Lydie & Suelle ~The Alchemists and the Mysterious Paintings~ 70010000007082 HACPAF49B
Atelier Marie Remake: The Alchemist of Salburg 70070000017204 HACYBANAC
Atelier Marie Remake: The Alchemist of Salburg 70010000059383 HACPBANAB
Nelke & the Legendary Alchemists ~Ateliers of the New World~ 70010000012906 HACPAQBXB
Atelier Shallie: Alchemists of the Dusk Sea DX 70010000021855 HACPAU3HB
Atelier Escha & Logy: Alchemists of the Dusk Sky DX 70010000021851 HACPAU3GB
Atelier Ayesha: The Alchemist of Dusk DX 70010000021852 HACPAU3FB
Atelier Lydie & Suelle: The Alchemists and the Mysterious Paintings DX 70010000038153 HACPA289B
Atelier Sophie: The Alchemist of the Mysterious Book DX 70010000038149 HACPA286B
Atelier Firis: The Alchemist and the Mysterious Journey DX 70010000038151 HACPA288B
Atelier Rorona ~The Alchemist of Arland~ DX 70010000014626 HACPAQYTB
Atelier Meruru ~The Apprentice of Arland~ DX 70010000014714 HACPAQYVB
Atelier Lulua ~The Scion of Arland~ 70010000015810 HACPARC6B
Atelier Arland series Deluxe Pack 70010000015854 HACPAQYTB
Atelier Dusk Trilogy Deluxe Pack 70010000025993 HACPAU3FB
Atelier Mysterious Trilogy Deluxe Pack 70070000012090 HACYA4CVA
Atelier Ryza: Ever Darkness and the Secret Hideout 70010000021547 HACPAT8AB
Game Builder Garage 70010000041268 HACPAWUXA

So I'm guessing is an issue on Nintendo's side.

Cheers, Fede.