context.params.permitted not set in child hook about feathers-permissions

[daffl]

checkPermissions will just return a hook function. You either have to call it with the context and await it or explicitly add it to the hook chain as recommended in the documentation:

get : [
  authenticate('jwt'),
  checkPermissions({
    roles: ['admin', 'user'],
    error:  false
  }),
  checkForAccess()
],

With a checkForAccess that calls the hook function like this:

const { restrictToOwner } =require('feathers-authentication-hooks');
const restrict = restrictToOwner({ idField:  'id', ownerField:  'id' });

module.exports = function (options  = {}) {
  return  async  context  => {
    if(!context.params.permitted) {
      return restrict(context);
    }
  }
};

[greenspray9]

wow thank you for your blazingly fast response! Apologies in advance if my question was not well formulated. I did read through the documentation and didn't know that it would return a hook function. I tried your method but context.params.permitted is still undefined.

[daffl]

With the example I gave I don't think there is a way it could be undefined. You could also change your original checkForAccess to:

const { restrictToOwner } = require('feathers-authentication-hooks');
const restrict = restrictToOwner({ idField:  'id', ownerField:  'id' });
const check = checkPermissions({
  roles: ['admin', 'user'],
  error:  false
});

module.exports = function (options  = {}) {
  return async ctx => {
    const context = await check(context);

    if(!context.params.permitted) {
      return restrict(context);
    }

    return context;
  }
};

[greenspray9]

thank you! that helped my case. I noticed that sometimes the context.params is just {} so i added another predicate to check for the size of the object. This is my updated code if anyone in the future also gets stuck in this

const checkPermissions = require('feathers-permissions');
const { restrictToOwner } = require('feathers-authentication-hooks');
const restrict = restrictToOwner({ idField:  'id', ownerField:  'id' });

const check = checkPermissions({
  roles: ['admin', 'user'],
  error:  false
});

module.exports = function (options  = {}) {
  return async context => {
    context = await check(context);
    if(Object.keys(context.params).length !== 0 && !context.params.permitted ) {  
      return restrict(context);
    }
    return context;
  };
};

[daffl]

Great, thank you for sharing.