Coder Social home page Coder Social logo

Comments (3)

cardoe avatar cardoe commented on July 30, 2024

I should mention that Iterator.zip() doesn't work if the style iterator has less items than the data iterator because zip() stops when any of the iterators run out of data. So people would be confused why their data was being truncated.

from tui-rs.

fdehau avatar fdehau commented on July 30, 2024

Hi, there are several valid points here. First of all, there are certainly a lot of places in the code where there is room for improvements regarding both the API exposed to the caller and the performance.

I took the liberty to implement your ideas in a dedicated branch #11. The major change required for this to work is to update the Widget signature. Indeed, until now the draw call was done using a simple & to the widget. Consuming the iterator inside the draw call would then require &mut if I'm not mistaken. This change the behavior of the widget that should now be seen as a "consumable" object. However, this does not appear to me as problem since it was one of the goals of the library anyway.

I would appreciate your feedback on this if you have some time :)

from tui-rs.

cardoe avatar cardoe commented on July 30, 2024

Looks good. Sorry for the delay in looking at it. There were some other changes to the API so that delayed me a bit from trying it out. I like it.

from tui-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.