Coder Social home page Coder Social logo

Comments (4)

fdehau avatar fdehau commented on July 30, 2024

First of all thank you for taking the time to look into this since I've overlooked this issue until now.

Regarding your first point while I think that solution (A) is an easier path for the fix, solution (B) appears to be more future proof.

Regarding percentages you are making a very good point and moving to floats for better precision is ok for me.

I'm also interested in your setup for testing those cases if you don't mind sharing.

from tui-rs.

karolinepauls avatar karolinepauls commented on July 30, 2024

The setup is me rescaling a console window way over what my screen is (and getting frustrated doing so). 2^16 is not that much. At work my console window is stretched across 2 HD screens, which is halfway there.

In order to properly test conditions like that a virtual terminal backend may come in handy.

This issue is a bit about too many things at once, so for now I'll play with the ideas here and then I may come up with some PRs. Otherwise - feel free to split it.

from tui-rs.

karolinepauls avatar karolinepauls commented on July 30, 2024

#92 "resolves" artefacts with backends over 2^16 characters.

Percentage remains unresolved (I may look into it but last time I tried to do something, it took me so long that meanwhile you implemented an equivalent :D).

from tui-rs.

fdehau avatar fdehau commented on July 30, 2024

That's great 👍. As you suggested earlier, I think promoting dimensions to u32 might be the next step to cover most use cases. In the meantime, thanks to your work, we have an elegant solution to this problem =).

from tui-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.