markAsRead is not marking thread as read about fbchat

[Schmavery]

In my experience, including __dyn makes no difference.

[bsansouci]

@actionless if you love reading minified code, feel free to log into FB, download the whole page and all JS and all, grep __dyn and figure out how it's generated. From my two past attempts, that baby's hard to figure out (though @Schmavery and I have figured out all of the other "encryption schemes" happening). As @Schmavery said, it doesn't seem to make a difference so far (let's not jinx it)

[actionless]

is markAsRead works for anyone here?
or it's something wrong with my setup

[actionless]

@Schmavery is it works in your js implementation btw?

[PidgeyL]

@actionless Did you also run "MarkAsSeen"? I'm not 100% sure on what the difference is, but there is one...

[actionless]

just for the better understanding, the test code:

def print_new_messages(facebook_id, facebook_password):
    client = fbchat.Client(facebook_id, facebook_password)
    user_ids = client.getUnread()['unseen_threads'][0]['other_user_fbids']
    if not user_ids:
        print("No new messages")
        return
    for user_id in user_ids:
        print("{}:".format(user_id))
        for message in client.getThreadInfo(user_id, 0):
            if message.is_unread:
                print((message.subject, message.body))
                client.markAsDelivered(user_id, message.message_id)
        client.markAsRead(user_id)
    client.markAsSeen()

test case to reproduce the issue:

1. send a message to facebook account
2. execute that code snippet, it should print the new message
3. send one more message
4. execute code snippet once again

expected result:
only the latest message was printed to the console

actual result:
both message from pt.1 and 3 are displayed (message.is_unread remains True)

but after opening in the browser and running code snippet once again those messages are marked as read so not displayed

[actionless]

so can anyone confirm the issue?

[bsansouci]

@actionless hey, looking at our implementation (from which this is based on), this is what we do. I difference is the form sent to change_read_status.php contains a list of threadIDs instead of userIDs. Try calling it with a threadID and see what happens.

[actionless]

unfortunately it's still behave the same

[horik]

in order to work markAsRead, please fix
" data["ids[%s]"%userID] = True " => " data["ids[%s]"%userID] = 'true' "
this value mast be in lowercase.

[horik]

override

class Client(fbchat.Client):
    def markAsRead(self, userID):
        data = {"ids[%s]" % userID: 'true'}
        r = self._post(fbchat.client.ReadStatusURL, data)
        return r.ok

[actionless]

@thnkloud9 if you are still working on the project, see above

[madsmtm]

Assuming this has been fixed