Comments (5)
Hm but reflect.Indirect
is returning the value itself if it's not a pointer. And I need the value to set the field. See: http://golang.org/src/pkg/reflect/value.go?s=66983:67011#L2249
Here are the tests fro set https://github.com/fatih/structs/blob/master/field_test.go#L46
Could you add a test case that invalidates this test so I can be sure what the real problem is?
from structs.
I've forked your repository and added a test that fails.
https://github.com/pikanezi/structs
Basically:
type Bar struct {
A string
}
type Foo struct {
B *Bar
}
foo := &Foo{
B: nil,
}
structInfo := structs.New(foo)
bar := &Bar {
A: "helloWorld",
}
err := structInfo.Field("B").Set(bar); err != nil {
fmt.Println(err) // Prints "field is not settable"
}
from structs.
Thanks! I'll look it into asap.
from structs.
Thanks for the case. I've added it to the test cases and fix the problem. As you said earlier there is no need to take the address as that would disallow to set it. 👍
from structs.
Glad I could help :)
from structs.
Related Issues (20)
- Custom Map function HOT 1
- Report fields of anonymous fields HOT 2
- stack overflow on structs.Map() HOT 1
- Add Addr method for Field HOT 1
- structs.Map return empty map HOT 3
- Range over nested slice of structs (using fields) HOT 3
- structs.Values() does not parse time.Time field HOT 2
- Why don't cache type information that has been reflected ? HOT 1
- Custom how nested struct marshals HOT 2
- Nested reflection? HOT 1
- How about add a api for convert map to structs? HOT 3
- Changing case of field name(key) in the generated map HOT 3
- Versions and tags HOT 4
- Proposal: Create a map and omit nil values HOT 3
- Nested structs HOT 1
- Get tag-value without omitempty HOT 2
- New() with options HOT 2
- I get empty return for this HOT 1
- panic when using both flatten and omitempty HOT 1
- Values that are structs lose their tags HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from structs.