Comments (3)
Yeah I think this should be done inside faillint. I've added this functionality into Fixmie once. Here is an example how golint
does it:
I think we can use this package for that: https://dmitri.shuralyov.com/go/generated
And we can also probably add a file or flag to ignore certain files as well when there is no Generate directive inside the file. We do it now via --ignore-tests
, but maybe we can add --ignore-files="pb.go"
or something similar.
from faillint.
(some brain dump, didn't looked detailed yet):
think this could be a separate Analyzer so it's pluggable. The Analyzer is pluggable and uses graph inside and you can require
certain Analyzers. The reason is to make the Analyzers composable. I think a fatih/generated
analyzer or fatih/faillint/generated
analyzer could be used as well.
from faillint.
I implemented this and tested internally in some of our code base and it work sell. I'm planning to merge it in the morning (PST).
from faillint.
Related Issues (18)
- Ignore vendor dir HOT 1
- Ignore Tests HOT 3
- Comment imports to tolerate exceptions HOT 10
- Add failing for certain methods in a given package (i.e: fmt.Errorf) HOT 10
- Add support to path prefixes HOT 3
- Parse paths from a configuration file
- Dot imports
- Possibility to detect function from a struct
- [Feature Request] Autofix support HOT 1
- Analyse go files with buildtags HOT 3
- Error "could not import C" when using CGO HOT 3
- Error `constant overflow` for `-math.MaxFloat64` HOT 2
- [Feature Request] Support excluding packages HOT 4
- Add ability to lint only test/benchmark/fuzz functions HOT 1
- package imported without types errors when using with Go 1.18 HOT 4
- Example of README: As an example, you could enforce the usage of github.com/pkg/errors instead of the errors package. HOT 1
- Panic while parsing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from faillint.