Coder Social home page Coder Social logo

Skip generated files. about faillint HOT 3 CLOSED

bwplotka avatar bwplotka commented on June 1, 2024
Skip generated files.

from faillint.

Comments (3)

fatih avatar fatih commented on June 1, 2024

Yeah I think this should be done inside faillint. I've added this functionality into Fixmie once. Here is an example how golint does it:

golang/lint@a5f4a24

I think we can use this package for that: https://dmitri.shuralyov.com/go/generated

And we can also probably add a file or flag to ignore certain files as well when there is no Generate directive inside the file. We do it now via --ignore-tests, but maybe we can add --ignore-files="pb.go" or something similar.

from faillint.

fatih avatar fatih commented on June 1, 2024

(some brain dump, didn't looked detailed yet):

think this could be a separate Analyzer so it's pluggable. The Analyzer is pluggable and uses graph inside and you can require certain Analyzers. The reason is to make the Analyzers composable. I think a fatih/generated analyzer or fatih/faillint/generated analyzer could be used as well.

from faillint.

fatih avatar fatih commented on June 1, 2024

I implemented this and tested internally in some of our code base and it work sell. I'm planning to merge it in the morning (PST).

from faillint.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.