fCWT matlab crash on Mac about fcwt

[fastlib]

What a coincidence! I was discovering exactly the same pragmatic solution as you did yesterday evening. After a few hours of tedious commenting and uncommenting and restarting Matlab 120+ times, I discovered that Matlab doesn't like OpenMP anymore. I'm not sure what the problem is, but for now a good solution is to use fCWT singlethreaded like you did in your pull-request.

Eventually, I merged your pull-request with mine and created a build time variable which I only use when building the mex-files via CMake. Additionally, I added some warnings for Matlab-users to make clear that their fCWT implementation does not support threads at the moment.

For now, the Matlab-wrapper should work again, but be it only single-threaded. I will leave this issue open as this is only a temporary solution.

[fastlib]

Thank you for pointing this out. We will release a fix soon.

[keigoyoshida7]

Thank you for answer me.
Also, I'm trying MEX file in matlab on windows (intel CORE i7)
but, there is a error with omp file may be...
Are there any wrong code in this picture or other problem?

(please teach us how can We use fCWT in matlab on windows...)

best regards,

[fastlib]

It seems no easy fix. If you want to use fCWT without C++, your best option would be to use the Python package. We will be looking into fixing the Matlab wrapper but that could take some time. Our apologies for the inconvenience.

[keigoyoshida7]

Thank you! please let us know when it is fixed.
best regards,

[felixdollack]

@fastlib I am wondering about O1 in this line of fcwt.cpp:

fCWT/src/fcwt/fcwt.cpp

Line 474 in e6e6c15

pinv = fftwf_plan_dft_1d(newsize, O1, (fftwf_complex*)poutput, FFTW_BACKWARD, FFTW_ESTIMATE);

It is initialized to 0

fCWT/src/fcwt/fcwt.cpp

Line 443 in e6e6c15

memset(O1,0,sizeof(fftwf_complex)*newsize);

but not filled with any data or used as output variable.

I can compile fcwtmex (on macOS) after adjusting for the new path of fcwt, but Matlab crashes randomly when calling fcwt.

That seems to work. See next comment...

[felixdollack]

fCWT_plan is redefining PI (comment it out) from fctw.h and it is missing
mwSize c0 = mxGetScalar(prhs[1]); before using it in Morl(c0);
After those modifications it compiles. But still does not run.

If I remove omp_set_num_threads(threads); from create_FFT_optimization_plan, I can run it.

%%%%%%
Edit: Nevermind, I missed another comment I made.

All calls to OMP and fftwf_plan_with_nthreads need to be commented out:

//omp_set_num_threads(threads);
//std::cout << "Threads:" << omp_get_max_threads() << std::endl;

fftwf_init_threads();
// fftwf_plan_with_nthreads(omp_get_max_threads());

%%%%%%

The same does work for cwt.

If fftw is run with a single thread there are no issues (except that it might be slower than intended? ^^)

[liu7645]

Hi
I want to run the code in matlab. My gcc could find openmp_c, but not find openmp_cxx. Could you please give me some advice? Oh, it's on windows.

[whip123]

Hi @fastlib,
Is there any way to run the full potential of fCWT in MATLAB such as using an older version of MATLAB?
Thanks