Comments (14)
@KrauseFx commented |
That's a good point and makes perfectly sense.
Right now, you can just comment out the ipa
line.
I'll add an option for this later today, thanks for letting me know.
from fastlane.
@KrauseFx commented |
@paweldudek seems to have implemented something like this already: https://github.com/paweldudek/deliver/commit/2a58241243513ba0dfda187332fad16e81391cf8
About the scary red button: You know you can very easily cancel the submission while Waiting for Review
?
from fastlane.
@DenHeadless commented |
@KrauseFx Yep, of course, but it's strange to cancel submission every time. At least for me, i would never want automatic submission for review, but it's very subjective, of course.
Anyway, thanks for great gem, it's a great addition to our build tools!
from fastlane.
@KrauseFx commented |
@DenHeadless Yes, I understand that.
I'll be working together with @paweldudek to implement this feature.
from fastlane.
@paweldudek commented |
@DenHeadless @KrauseFx should be able to bake a PR for this one tomorrow ๐
from fastlane.
@KrauseFx commented |
Awesome, thanks @paweldudek. As mentioned on your commit: It's okay to just send a PR with the new option in the ipa_uploader
. I'll implement the interface of the Deliverfile
and update the README.
from fastlane.
@mgrebenets commented |
Good to see progress on this request.
I just used deliver to upload an app and was puzzled when I realized that the ipa was actually submitted for review, not just uploaded.
For me the main concern was how did deliver
answer the compliance questions. The one about encryption and another one about IDFA. For IDFA there's yes/no option and then 3 checkboxes of which I have to check only the first one, then there's "I contest" checkbox at the bottom.
It would be a nice improvement to have these answers configurable in Deliverfile.
And finally deliver
could be used to upload ipa and then share it with beta testers via TestFlight.
P.S.
Thanks for an awesome gem! Keep up good work!
from fastlane.
@KrauseFx commented |
Both things you mentioned are possible:
I have to admit, I'm not sure the Compliance Questions are working. You can create a separate issue in case it's not working.
from fastlane.
@mgrebenets commented |
Cool, thanks for the links.
Right, there's no way to check compliance questions answers once the app is submitted for review, at least I can't find anything in iTC.
Probably taking screenshots of browser page with answers could be a valuable feature. To serve as reassurance for concerned developers.
from fastlane.
@KrauseFx commented |
Do you mean deliver
should take a screenshot of all opened pages and store them somewhere?
A screenshot of all available options can be found here.
from fastlane.
@mgrebenets commented |
No, I don't mean to screenshot all the pages, just important ones. Like that page with answers to compliance questions.
from fastlane.
@KrauseFx commented |
This functionality is now available in the master branch: fastlane-old/deliver#36
Please take a look at the bottom comments about how to install it. The new version was not yet released, still waiting for an okay from the other developers.
from fastlane.
@DenHeadless commented |
Thank you very much!
from fastlane.
@KrauseFx commented |
Can you try it and let me know if it works as expected?
from fastlane.
Related Issues (20)
- Individual API Key not supported HOT 3
- fastlane deliver init is not working in CLI
- JEG2/highline should be updated to avoid warning of abbrev missing in standard lib for ruby 3.3.0
- How to get raw exit code from Fastlane HOT 3
- Match import to s3 Crash on encrypting. HOT 2
- Provisioning profile expiration comparison compares Time and DateTime
- AvailableTerritories is deprecated and fastlane is not upgraded to new api endpoints HOT 5
- Match managing provisioning profiles for DriverKit HOT 1
- curb-1.0.0/lib/curl/easy.rb - Failed to read/open file HOT 1
- `match` behaves differently in v2.220.0: `wrong final block length` HOT 14
- Can't upload build to Test Flight; [!] undefined method `refresh!' HOT 2
- A parameter has an invalid value - 'prices' is not a valid relationship name HOT 12
- I run the command 'fastlane match development'. and i got the following error: Looking for related GitHub issues on fastlane/fastlane... Found no similar issues. To create a new issue, please visit: https://github.com/fastlane/fastlane/issues/new Run fastlane env to append the fastlane environment to your issue [!] The request could not be completed because: This request is forbidden for security reasons - You currently don't have access to this membership resource. Contact your team's Account Holder, or an Admin.
- Build_for_testing fails sporadically with error 'Could not find or use auto-linked framework' HOT 2
- Can fastlane support filling in Chinaโs ICP registration number?
- [match] provisioning profile generated via match blocks release installation on TestFlight (or on device) HOT 1
- if and switch expressions Swift HOT 1
- xcodes() stopped working -- no changes or updates HOT 3
- Verification codes canโt be sent to this phone number at this time. Please try again later
- Stucked when distributing iOS package to testflight external group
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastlane.