Comments (9)
You are right, body is more intuitive.
In addition, I'm developing the swagger plugin, and in the yaml file the payload is referenced as body.
I'm +1 on rename it, or at least make an alias.
@mcollina thoughts?
from fastify.
I'm 👍 on fixing the inconsistency. I'm fine both ways.
from fastify.
The problem with the "remove completely" is that we are not warning the user that we have changed the api. So probably use an alias until the v1.0 is the best way :)
from fastify.
<1.0.0 is volatile. So if you wanted to change it completely I don't see why you'd need to keep an alias around.
from fastify.
I'm 👍 in removing it completely right now.
from fastify.
Ahahaha, we are in democracy, 2 vs 1 :P
Let's go with the direct change then!
@jsumners do you want to make a pr?
from fastify.
I am unclear on the decided resolution (payload or body). I am fine with you implementing what you see as the solution @delvedor .
from fastify.
Body :)
Ok, I'll do it, thanks for the suggestion!
from fastify.
Done in #78
from fastify.
Related Issues (20)
- Overriding decorators for testing proposes
- sync next with main HOT 2
- Server.setTimeout is not implemented in Bun HOT 2
- Consider using alternative linters/formatters instead of eslint/standardjs HOT 12
- Benchmark workflow is broken HOT 5
- Create a new repo fastify/demo HOT 1
- Typescript tsc throws multiple errors and fails to compile with fastify 4.26.1 HOT 7
- Update docs with X-Ray plugin
- Vitest and Decorators of Plugins, not coming down HOT 2
- customErrorHandler is a mystery in the documentation HOT 2
- Coordinating the Renaming of `master` Branch to `main` Across Fastify Repositories HOT 2
- method to check if plugin version is matching the Fastify version HOT 3
- Different Type Providers for validation and serialization HOT 2
- Attaching .on('data', (chunk) => { }) to fs.createReadStream(filePath) returns incomplete/corrupted downloads on the client. HOT 4
- Critical error on compatibility with pm2 on automatically start service on system startup cases HOT 5
- Moderated
- Handling and validation of optional null values in JSON body HOT 3
- "Reply was already" sent error even though the onSend hook isn't returning a reply
- getting write after end error when using async preserialization hook HOT 1
- setSerializerCompiler bugs HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastify.