Coder Social home page Coder Social logo

Hooks context about fastify HOT 10 CLOSED

fastify avatar fastify commented on July 30, 2024
Hooks context

from fastify.

Comments (10)

mcollina avatar mcollina commented on July 30, 2024 1

Let's leave it as it is and this issue open, and maybe we'll do that if there is a need.

from fastify.

jsumners avatar jsumners commented on July 30, 2024 1

I claim there is definitely a need for this. As a concrete example, I am attempting to use it in fastify-caching to access this.cache so I can store an indicator that the resource can be served from the user's cache:

instance.addHook('onResponse', function (res, next) {
  if (!res.hasHeader('etag')) return next()
  this.cache.set(res.getHeader('etag'), true, 1000, next)
})

from fastify.

mcollina avatar mcollina commented on July 30, 2024 1

definitely 👍 . I think we should work on a PR after #330 lands.

from fastify.

jsumners avatar jsumners commented on July 30, 2024

Is there anyone familiar with how this works that is willing to start the PR now that #330 is merged? cc: @fastify/fastify

from fastify.

StarpTech avatar StarpTech commented on July 30, 2024

Should be easy, here a start:

from fastify.

StarpTech avatar StarpTech commented on July 30, 2024

I created a PR #408

from fastify.

StarpTech avatar StarpTech commented on July 30, 2024

I created a new one #414

from fastify.

jsumners avatar jsumners commented on July 30, 2024

It'd be really great if you simply pulled in upstream changes to an existing PR to resolve conflicts in the future.

from fastify.

StarpTech avatar StarpTech commented on July 30, 2024

For me it was easier to create a new one instead to merge the changes. I can take care about this in future.

from fastify.

StarpTech avatar StarpTech commented on July 30, 2024

Fixed in #414

from fastify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.