Coder Social home page Coder Social logo

Comments (3)

cowtowncoder avatar cowtowncoder commented on July 29, 2024

Hmmh. This could make sense; I am only slightly concerned about backwards compatibility. But this can definitely be done for 2.4?

from jackson-datatype-json-org.

laszlohordos avatar laszlohordos commented on July 29, 2024

This is the very same jar as the original org.json:json:20131018 except it was repackaged with different manifest file and it was deployed under different maven id. This is just a suggestion to improve this library and avoid the warning in IDE about a not OSGi compatible dependence.

I could only imagine one problem. If this dependency used in a project along with other dependencies which depends on org.json:json because the very same jar will be added twice. This is most likely valid only if it's used in non OSGi environment because in OSGi environment the project very likely have this in the Pom file:

I looked for other JSON packages in Maven but to me this one looks the preferred one because it has the source package too.

Before in OSGi project:

<dependency>
    <groupId>com.fasterxml.jackson.datatype</groupId>
    <artifactId>jackson-datatype-json-org</artifactId>
    <version>2.3.1-SNAPSHOT</version>
    <excludes>
        <exclude>
            <groupId>org.json</groupId>
            <artifactId>json</artifactId>
        </exclude>
    </excludes>
</dependency>
<dependency>
    <groupId>org.apache.geronimo.bundles</groupId>
    <artifactId>json</artifactId>
    <version>20090211_1</version>
</dependency>

This change makes this unnecessary any more. If someone want's to use the original org.json:json because multiple other project refers to that one then they must use this exclusion.

After:

<dependency>
    <groupId>com.fasterxml.jackson.datatype</groupId>
    <artifactId>jackson-datatype-json-org</artifactId>
    <version>2.3.1-SNAPSHOT</version>
    <excludes>
        <exclude>
            <groupId>org.apache.geronimo.bundles</groupId>
            <artifactId>json</artifactId>
        </exclude>
    </excludes>
</dependency>

from jackson-datatype-json-org.

cowtowncoder avatar cowtowncoder commented on July 29, 2024

Right, I am not concerned about package not being perfectly fine, but about duplicate instances; which may or may not be a real problem (quite possibly not since contents are identical or at least compatible).

I think I can make this change for 2.4, and we can branch version after 2.3.1 release that will be done soon.

from jackson-datatype-json-org.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.