Use of import * in the fastai library about fastai

[kongscn]

I would expect a more normal kind of python at least in the fastai package. Being easy to read and understand is more import than making it some lines shorter, the mental model decides how long or difficult a script is. But it looks like a new language at first glance 😢.

With import * I don't know something comes from which file, or from another package like torch. It's really more difficult to get a quick picture of a file even with IDE. and feels fragile.

[jph00]

Configure your editor or IDE to display this info and/or jump to the token. That's a computer's job, not a human's :)

If you're just browsing the code online thru github, install the sourcetree chrome extension to get the same functionality (in-project only).

[jeremyjordan]

@macsermkiat i'm sorry, but you can elaborate on why import * can improve the data science workflow? it severely hinders readability.

for example, suppose you have a file which has many import statements at the top.

from module_a import *
from module_b import *
from module_c import *
from module_d import *
from module_e import *

later in the code, a function some_random_function() is used but is not defined anywhere in the file. to trace the origins of this function, you would need to go search through each module until you find it.

compare that with readable import statements:

from module_a import some_function
from module_b import another_function
from module_c import some_random_function
...

you can quickly figure out where the function was defined.

[dbook-kkbrandt]

Wow, thank you for pointing us to this chrome extension - this is seriously the most useful Chrome extension I've ever seen, and it works wonderfully!
https://chrome.google.com/webstore/detail/sourcegraph-for-github/dgjhfomjieaadpoljlnidmbgkdffpack

[macsermkiat]

Jeremy had pointed that out somewhere in the VDO. Import *might be bad generally. But for datascience work, it helps in better workflow.

[iskode]

Jeremy plans to make the lib more documented, but he showed some tip to know where a class or function comes from:
?unknown_function + Enter
Alternatively you can put the cursor in the first bracket of the function and type Alt + Tab to see the docs.