CommitSHA.h incorrectly formatted about farmbot-arduino-firmware

[jsimmonds2]

Ooops, sorry, my environment is Fedora Linux 64bit version 32 Workstation

Linux f32v-on-comet 5.8.10-200.fc32.x86_64 #1 SMP Thu Sep 17 16:48:25 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

make --version
GNU Make 4.2.1
Built for x86_64-redhat-linux-gnu
Copyright (C) 1988-2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

Wonder why Makefile doesn't create a useable CommitSHA.h on this platform !? ( but works on CircleCI ! )

[jsimmonds2]

Found it. I'll send a PR for Makefile.

PR157

[gabrielburnworth]

Thanks for identifying and fixing the issue in your environment! As you mentioned, the previous code has been working on CI (and our systems) because it was using the builtin echo, which didn't need the -e option. Also, as you may have noticed on CI, adding the -e option didn't work with the builtin so I changed it to /bin/echo to avoid environment confusion.

[jsimmonds2]

@gabrielburnworth thanks so much for sorting out a better solution ❤️

[ For my own learning, . . Which Linux and which Shell are used in CircleCI ? ]

F.y.i. While researching my solution I discovered that "best-practice" Makefiles define a SHELL near the beginning 🙂

[gabrielburnworth]

CircleCI uses Ubuntu.

Thanks for the tip. (Reference docs: choosing the shell, conventions)

I've added:

farmbot-arduino-firmware/Makefile

Line 1 in 099bb70

SHELL = /bin/sh