Support Firefox add-ons execution environment about pjax-api

[EnixCoda]

It works! Thank you so much!

Now I can release next version of Gitako and users will have better user experiences!

If you use GitHub frequently, please give a try :P

https://github.com/EnixCoda/Gitako

[falsandtru]

I fixed cross-origin access only about window.history.state. Is there another illegal access?

e.g. assigning variables to properties of window.location

If you actually get that error, can you also show me it and its call stack?

[EnixCoda]

Thank you for fast responding!

Here are screenshots of each level of the call stack, top down.

It looks like that the issue happens when assigning position to window.history.state?

[falsandtru]

OK, it should be fixed at v3.31.1. Can you confirm it?

[EnixCoda]

It's not :(

The issue occurs in savePosition while your changes updated mutations on state in functions except it.

savePosition is still mutating on cross origin state.

pjax-api/src/layer/data/store/state.ts

Lines 30 to 40 in c22b440

	export function savePosition(): void {
	void window.history.replaceState(
	extend<Pick<State, State.position>>(
	window.history.state || {},
	{
	position: {
	top: window.pageYOffset,
	left: window.pageXOffset
	}
	}),
	document.title);

[EnixCoda]

Sorry, I missed later commits in which you fixed savePosition.

But the issue does still exist after I updated pjax-api. I'll remove local cache and give another try ASAP.

[EnixCoda]

The cross-origin issue has been fixed successfully! 🍻

...and another occurred - TypeError: can't prevent extensions on this proxy object

It is an issue of URL.

Call stacks

The direct reason

I did some dig on it (see the console). It seems that the reason is Object.freeze failed on URL instances.

[falsandtru]

OK, I'll remove Object.freeze.

[falsandtru]

Fixed at v3.31.2.