Coder Social home page Coder Social logo

Comments (3)

CaselIT avatar CaselIT commented on May 18, 2024

seems that what they want you to do for #reasons is the following

try:
  loop = asyncio.get_running_loop()
except RuntimeError: # lol custom exception are for noobs
  loop = asyncio.new_event_loop()
  asyncio.set_event_loop(loop)

I have no idea how someone looked at this and thought "yeah that's a great api to replace get_event_loop" -.-'

from falcon.

CaselIT avatar CaselIT commented on May 18, 2024

seems that what they want you to do for #reasons is the following

try:
  loop = asyncio.get_running_loop()
except RuntimeError: # lol custom exception are for noobs
  loop = asyncio.new_event_loop()
  asyncio.set_event_loop(loop)

I have no idea how someone looked at this and thought "yeah that's a great api to replace get_event_loop" -.-'

nope that's too simple. the following seems correct

def get_event_loop() -> asyncio.AbstractEventLoop:
    try:
        return asyncio.get_running_loop()
    except RuntimeError:
        # avoid "During handling of the above exception, another exception..."
        pass
    if sys.version_info < (3,12):
        return asyncio.get_event_loop()
    else:
        with warnings.catch_warnings(action='error'):
            loop = None
            try:
                loop = asyncio.get_event_loop()
            except (DeprecationWarning, RuntimeError):
                # avoid "During handling of the above exception,
                # another exception..."
                pass
            if loop is None:
                loop = asyncio.new_event_loop()
                asyncio.set_event_loop(loop)
            return loop

from falcon.

vytas7 avatar vytas7 commented on May 18, 2024

See also the discussion on python/cpython#100160

from falcon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.