Coder Social home page Coder Social logo

Comments (1)

sveinugu avatar sveinugu commented on May 29, 2024

This refers to the equality check of the Model class, tested here: https://github.com/fairtracks/omnipy/blob/da30c3c12bb260ee79419b7f78a4b2bf061f357b/tests/data/test_model.py#LL76C5-L76C18

Pydantic only checks the value when comparing equality of a BaseModel class, not differences in the model itself. Without this change in omnipy then Model[list[Any]]([123]) == Model[list[int]]([123]). However, we want `Modellist[Any] != Modellist[int]. This is now fixed for the Model class. This TODO is about fixing the same for the Dataset class (test-driven, so write the test first).

@pavelvazquez I think this is a good task for you to begin with while I am away.

from omnipy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.