faeldon / philippines-json-maps Goto Github PK

Feature request. in geojson?

First of all, thanks for providing this repository. I've been looking for something like this. However, I am having problems reading the shapefile with geopandas.

Description

geopandas readfile not recognizing a legit shape file

Steps to reproduce

1. Attempt to read with geopandas.read_file() command:
   gpd.read_file('https://github.com/altcoder/philippines-psgc-shapefiles/blob/master/source/2015/Municities.zip')
2. I get a driver error:
   DriverError: '/vsimem/dff0663a4e584987848e40266f6b73e8' not recognized as a supported file format.
3. Searching google and stack overflow unfortunately did not produce useful clues.

Expected behavior
A GeoDataFrame object.

Description

I trying to create an interactive map based from leaflet and I'm testing out this project of yours and I encounter a missing GeoJSON files particularly only for NCR region.

Steps to reproduce

1. Click Region:
   
2. Click a province
   
3. Click a municities (on the picture below, I'm clicking NCR, Second District (Not a Province))
   
4. Checking console (checking console reveals that the geometry has 0 length array)
   

Expected behavior
The expected output should show places/municities under the NCR region.