Coder Social home page Coder Social logo

Comments (5)

facontidavide avatar facontidavide commented on July 26, 2024

With the new sync, master will be the same as kinetic. I changed the API in a non compatible way. If you look at the unit tests, you will see how the new API is used.
The most noteworthy difference is that renamed_value is a separate vector with use std::string instead of SString.
This resulted in a considerable speed improvement, especially if you reuse the vector multiple times to avoid memory allocation

from ros_type_introspection.

facontidavide avatar facontidavide commented on July 26, 2024

The operator double () was removed because there are situations in which it causes numerical errors. I want the user to use the method convert() to be more aware about what is going on.

from ros_type_introspection.

mehditlili avatar mehditlili commented on July 26, 2024

Thanks, it is more clear now. I have done some work on my side to make access to data simpler for my use case (one vector for all data, including strings), not sure about the efficiency though. As it is changing the API again, I won't do a pull request. Or I'll maybe put it in a different feature branch if you want to review it.

from ros_type_introspection.

facontidavide avatar facontidavide commented on July 26, 2024

Send the PR, I will be happy to review it

from ros_type_introspection.

facontidavide avatar facontidavide commented on July 26, 2024

Hi @mehditlili,

this is one of those bad/good news.

good news is that based on your suggestions, and the one of another user, I am preparing a PR for the 1.0 version that will introduce the changes we discussed.

#11

The bad news is that the API will change, but adapting your code should take you only 5 minutes.

from ros_type_introspection.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.