Coder Social home page Coder Social logo

Comments (4)

facelessuser avatar facelessuser commented on August 16, 2024 1

Worse case scenario, I think I can disable selectors that I cannot make work for Python < 2.7.5. I should be able to setup a portable Python 2.7.4.1 environment on my system to at least analyze the issue. If I can confirm, and more importantly resolve, then I'll add a fix. If I can't resolve the issue, I may just disable that selector for Python < 2.7.5.

from soupsieve.

facelessuser avatar facelessuser commented on August 16, 2024

Hmm, that is a pretty old version of Python 2.7. I don't explicitly test versions that old. I probably have no intentions of explicitly supporting anything below 2.7.

If the fix is easy enough, I don't mind adding it for < 2.7.5. I'd have to first identify what the issue is first. It looks like we would be providing a workaround for a bug in the old regex version in regards to * patterns I imagine, but I'm not sure yet.

from soupsieve.

facelessuser avatar facelessuser commented on August 16, 2024

I'll have to see if I can even get access to a python version that old...

from soupsieve.

facelessuser avatar facelessuser commented on August 16, 2024

FYI, this is not related to < 2.7.5, but instead seems to be < 2.7.4. The issue is actually this sub-pattern:

VALUE = r'''(?:"(?:\\.|[^\\"]*)*?"|'(?:\\.|[^\\']*)*?'|{ident}+)'''.format(ident=IDENTIFIER)

It should be as follows to work on older Python 2.7:

VALUE = r'''(?:"(?:\\.|[^\\"]+)*?"|'(?:\\.|[^\\']+)*?'|{ident}+)'''.format(ident=IDENTIFIER)

Subtle. It shouldn't normally break a regular expression engine, but using + in this case does make more sense.

from soupsieve.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.