Coder Social home page Coder Social logo

Comments (5)

oliverzx avatar oliverzx commented on September 27, 2024 2

You both are right. Epic indeed renamed things like TAssetPtr & FStringAssetReference (among some others) and deprecated them. Yet they didn't do it like they usually do with giving warnings. But that's purely not to spam the build log to the customers - which is a questionable decision imho.

They even commented on those on the redirectors:
// Not deprecating these yet as it will lead to too many warnings in games
//DEPRECATED(4.18, "FStringAssetReference was renamed to FSoftObjectPath as it is now not always a string and can also refer to a subobject")
typedef FSoftObjectPath FStringAssetReference;

// Not deprecating these yet as it will lead to too many warnings in games
//DEPRECATED(4.18, "TAssetPtr was renamed to TSoftObjectPtr as it is not necessarily an asset")
template<class T=UObject>
using TAssetPtr = TSoftObjectPtr<T>;

So yes, we should fix them until the next release.

from facefx-ue4.

jcredmond avatar jcredmond commented on September 27, 2024 1

Ok, I can do that today.

from facefx-ue4.

jcredmond avatar jcredmond commented on September 27, 2024

The plugin compiles in 4.18 with no deprecation warnings and no errors.

Is this enforced? If so, since when? Epic didn’t follow their normal rename / deprecation procedure then. Usually, for deprecation Epic marks stuff to emit warnings and then actually removes it out a release or two later. For renames, however, they typically just rename it such that it produces a compilation error.

The old names are still there and still work. Is this causing a problem for you?

from facefx-ue4.

jcredmond avatar jcredmond commented on September 27, 2024

@oliverzx do you any insight to this?

from facefx-ue4.

jcredmond avatar jcredmond commented on September 27, 2024

I used ripgrep and sed on macOS to do this (macOS sed requires the empty argument after -i, unlike Linux):

$ rg -l TAssetPtr | xargs sed -i '' 's/TAssetPtr/TSoftObjectPtr/g'
$ rg -l FStringAssetReference | xargs sed -i '' 's/FStringAssetReference/FSoftObjectPath/g'

Then I built a rocket build for the official 4.18.0 release (no warnings or errors), and everything worked; though I did not do extensive testing.

from facefx-ue4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.