Docker image fails because of the missing libboost_regex.so.1.65.1 shared lib about logdevice

[mateusz-gozdek-sociomantic]

Maybe rather than cleaning up the dependencies, use multi step build (2nd FROM and COPY) and just copy over binaries and install runtime dependencies? This way you don't need to do any cleanups, which might be error-prone (as the issue).

[mateusz-gozdek-sociomantic]

I'd have to sing CLA I guess, which seems to be too much hassle :)

I'd split ubuntu.deps into build deps and runtime deps and then follow https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#use-multi-stage-builds

[calebmarchent]

@MohamedBassem has passed his work-in progress changes over to me, I'll be picking this up next

[calebmarchent]

Update taking @MohamedBassem 's work forward; I now have a work in progress branch on my fork:
https://github.com/calebmarchent/LogDevice/tree/multistep_docker_ubuntu
This builds a docker image that can run the LogDevice cluster; image size: 340MB.

Next I'll add in more components to get all the tools working and do some testing.

[calebmarchent]

Yes, I can confirm we have been a little overzealous in clean-up of Dockerfile, having completed the build.

[AhmedSoliman]

That sounds like a good strategy @mateusz-gozdek-sociomantic. Would you like to send a PR to address that?

[AhmedSoliman]

@MohamedBassem are you going to send a PR for this or should we close that one?

[calebmarchent]

I have published a pull request: #23

[calebmarchent]

PR #23 is now merged; closing issue