Suboptimal usage of shared_ptr in a multi_index_container about logdevice

[tau0]

Joaquín, thanks for the report!

I confirm it's an issue and I can take a look into it. Unless of course you would like to submit a PR yourself?

[joaquintides]

I'm afraid I don't have the time to replicate a local environment in which to do the change. From a visual inspection, seems like the only changes need are:

In AllServerReadStreams.h, from:

boost::multi_index::multi_index_container<
  std::shared_ptr<ServerReadStream>,

to:

boost::multi_index::multi_index_container<
  ServerReadStream,

and from:

template <typename I>
static constexpr ServerReadStream& deref(I& it) {
  return const_cast<ServerReadStream&>(**it);
}

to:

template <typename I>
static constexpr ServerReadStream& deref(I& it) {
  return const_cast<ServerReadStream&>(*it);
}

In AllServerReadStreams.cpp, from:

auto stream = std::make_shared<ServerReadStream>(
    read_stream_id, client_id, log_id, shard, stats_, log_group_path);

const auto insert_result = streams_.insert(std::move(stream));

to:

const auto insert_result = streams_.emplace(
    read_stream_id, client_id, log_id, shard, stats_, log_group_path);

and from:

 (*it)->...

to:

it->...

If there are additional adjustments to be made the compiler will surely indicate it with an error.