Comments (3)
While playing around with the Fedora docker containers I noticed that setting _boost_py_component
to python3
works in the Ubuntu container as well! In both Fedora and Ubuntu (and Arch), libboost_python3
is symlinked to the file using the distro custom versioning scheme. Because of this, it can be detected when _boost_py_component
is python3
.
However, this may cause issues when a specific python version is needed, and I believe logdevice specifically requires python 3.6 (because of nubia
facebookarchive/python-nubia#2). If the main goal is to simply get the containers working, I would suggest setting the _boost_py_component
to python3
and be done with it, as they are using python 3.6.
If 3.7 support is achieved in nubia
, I see no drawbacks to setting _boost_py_component
to python3
, as a check for a minimum python version is made here (which should be updated to 3.6) https://github.com/facebookincubator/LogDevice/blob/2c0d9d5d9a38dfc5e60886acabc0a036eb43031e/logdevice/CMake/logdevice-deps.cmake#L8
Let me know your thoughts and I'll send a PR your way.
from logdevice.
Sorry that its taken a while to get to this one, the python3 is good, except for on Ubuntu Xenial, a platform for which I still need LogDevice to be able to build. I had a good look around the internet to see if any reliable solutions existed and I finally conclude that they simply don't; I understand there is an aspiration to "re-vamp" the FindBoost logic; but of course that would only be deployed into newer distribution versions.
Re-writing (including) a customised version of the FindBoost.cmake file, might be an option, but there is a lot of logic there that would end up with maintaining divergent code.
This leaves us with trying the different expected combinations, until one works; using a CMake foreach() loop or the like?
Please let me know your thoughts?
from logdevice.
Fixed by: #55
where we first try python3, if that fails, retry with python-py35, which catches the Ubuntu 16.04 case.
from logdevice.
Related Issues (20)
- Inconsistent column type for node_id in Sequencer and Nodes table HOT 3
- Settings abort-on-failed-check, abort-on-failed-catch and external-loglevel don't correctly subscribe to settings update HOT 1
- Tests failed in master due to some folly singletons being used without calling folly init
- Make DSCP reflection configurable in server settings HOT 1
- ModuleNotFoundError: No Module named 'libfb' HOT 1
- LogDevice build failing on Ubuntu bionic HOT 4
- logdevice/build_tools/fedora.deps file doesn't exist HOT 2
- With latest code, linking integration_test fail with SIGSEGV
- The log range specified must be positive 62-bit with start smaller or equal than end of range, supplied range is 0..200000 HOT 3
- Can not build on Ubuntu 19.10 HOT 3
- Will sequencer become a bottleneck for large size record with high throughput HOT 4
- Replication policy cross multiple cities with one special deferred? HOT 4
- Can not build on Ubuntu 18.04.4 HOT 2
- Conditional add question HOT 2
- Run quickstart through docker image failed HOT 1
- I want to integrate Kubernetes with VirtualLog. HOT 1
- Docker build fbthrift compilation thrift/lib/py3/test/gen-py3/testing/clients.cpp failed
- Is this project no longer maintained? HOT 12
- [email protected]
- LogDevice cluster start error --- NOSEQUENCER and sequencer:[invalid NodeID]
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from logdevice.