Coder Social home page Coder Social logo

Comments (3)

skindstrom avatar skindstrom commented on July 18, 2024

While playing around with the Fedora docker containers I noticed that setting _boost_py_component to python3 works in the Ubuntu container as well! In both Fedora and Ubuntu (and Arch), libboost_python3 is symlinked to the file using the distro custom versioning scheme. Because of this, it can be detected when _boost_py_component is python3.

However, this may cause issues when a specific python version is needed, and I believe logdevice specifically requires python 3.6 (because of nubia facebookarchive/python-nubia#2). If the main goal is to simply get the containers working, I would suggest setting the _boost_py_component to python3 and be done with it, as they are using python 3.6.

If 3.7 support is achieved in nubia, I see no drawbacks to setting _boost_py_component to python3, as a check for a minimum python version is made here (which should be updated to 3.6) https://github.com/facebookincubator/LogDevice/blob/2c0d9d5d9a38dfc5e60886acabc0a036eb43031e/logdevice/CMake/logdevice-deps.cmake#L8

Let me know your thoughts and I'll send a PR your way.

from logdevice.

calebmarchent avatar calebmarchent commented on July 18, 2024

Sorry that its taken a while to get to this one, the python3 is good, except for on Ubuntu Xenial, a platform for which I still need LogDevice to be able to build. I had a good look around the internet to see if any reliable solutions existed and I finally conclude that they simply don't; I understand there is an aspiration to "re-vamp" the FindBoost logic; but of course that would only be deployed into newer distribution versions.

Re-writing (including) a customised version of the FindBoost.cmake file, might be an option, but there is a lot of logic there that would end up with maintaining divergent code.

This leaves us with trying the different expected combinations, until one works; using a CMake foreach() loop or the like?

Please let me know your thoughts?

from logdevice.

calebmarchent avatar calebmarchent commented on July 18, 2024

Fixed by: #55
where we first try python3, if that fails, retry with python-py35, which catches the Ubuntu 16.04 case.

from logdevice.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.