Comments (5)
Thanks for reporting @drach. I'll look into it.
There is also a chance that the problem lies into fullbench
rather than zstd
.
Since you provide the sample to reproduce the issue, investigation should find it.
from zstd.
I believe to have fixed this issue within latest update of "dev" branch 695a6cb.
The issue was within fullbench
, zstd
library looks unaffected (by this bug).
fullbench
improperly allocated space for the ZSTD_decodeSeqHeaders
test, which was extended by one cell in recent versions of FSE.
Since the issue is not specific to your sample, I'm surprised it has not show up earlier within Continuous Integration tests, as fullbench
is tested with asan
enabled. I suspect FSE dynamically downsizes reference sample statistics as they are generated from a small sample. Side effect : it doesn't test the limits of internal buffers.
If you witness some instability issues outside of fullbench
, it may be related to something else.
from zstd.
Indeed, fullbench
is fixed in "dev", thank you.
If you witness some instability issues outside of fullbench, it may be related to something else.
Agree, will check it closer.
from zstd.
In an existing quite a big iOS app the invocation of ZSTD_decompress (exactly this function, not its internals) may just crash after several dozens of successful calls, it looks like a problem in a corrupted stack.
I was wrong. We call ZSTD_decompress
in different threads, some of them are set up with a 128Kb stack size that turns to be small for a ZSTD context. I was careless to notice it at first because the same code and data worked normally with LZ4 and Zlib's DEFLATE.
from zstd.
Thanks for feedback @drach.
Which reminds me : the decompression context is quite large currently, and it's part of my todo list to tame it.
In the meantime, should you need to keep your stack at 128K per thread, I suggest creating a context per thread with ZSTD_createDCtx()
, and use ZSTD_decompressDCtx()
(which is not yet exposed unfortunately, but present within zstd_decompress.c
). It will avoid usage of the stack.
from zstd.
Related Issues (20)
- Windows binaries are missing on v1.5.6 release HOT 3
- Clicking the website URL on GitHub repository displays a warning if browser is in HTTPS-only mode
- MSVC CMake build failed on v1.5.6
- v1.5.6 Windows binary downloads are double zipped HOT 4
- Raise version's in win32 binaries header HOT 3
- Why was the new release 1.5.6 removed? HOT 15
- long file names are cut off in output HOT 3
- Should zstd check archive consistency before overwriting files? HOT 1
- Should zstd delete incomplete archives? HOT 5
- 32-bit x86 build failure with 1.5.6 HOT 3
- v1.5.6 breaks 32-bit Windows clang-cl build HOT 3
- Decompress multiple zstaa backups on FAT32 drives HOT 4
- Replication of bug #3517 HOT 24
- Separate dictionary references to enable dictionary usage for any combination of window size and content size HOT 1
- Decompression speed regression in zstd 1.5.6 (win)
- Embed hash of raw dictionary in compressed resource (optionally) HOT 4
- Decompression crash after upgrading from zstd 1.4.5 to 1.5.6 HOT 12
- Missing check on failed allocation leads to NULL-ptr dereference
- libzstd.lib missed in package, also VC sample seems include wrong mem.h or ambigious including!
- Environment variable for --memory HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zstd.