Complete quoting for parameters of some CMake commands about wdt

[ldemailly]

thanks, can you give an example ?

—
Sent from Mailbox

On Sun, Jul 26, 2015 at 12:46 AM, Markus Elfring [email protected]
wrote:

A few parameters are passed to CMake commands in your build script without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.

Reply to this email directly or view it on GitHub:
#18

[elfring]

Update candidates:

• ${CMAKE_CURRENT_SOURCE_DIR}/deps/folly
• ${GLOG_INCLUDE_DIR}
• ${SOURCE_DIR}/include

[ldemailly]

I meant an example of error one would get with the current cmake - will look at the wiki (proper quoting is important in shell scrips - and we do have that issue in ours - but cmake isnt running commands per so I am curious)

[elfring]

Do you get any further ideas from other bug reports and corresponding update suggestions?

[ldemailly]

Ok, I'm adding "" around variable references but to be honest I'm not sure supporting ";" inside pathname is really important - is it ?

Looking forward to your testing of the upcoming updated Cmake

[elfring]

Thanks for your improvement of a build script.