Comments (8)
just fixing the error message in this case to not suggest WRITE_EXTERNAL_STORAGE is missing would help people not get stuck
from screenshot-tests-for-android.
hmm, I admit I haven't been testing this on M devices.
Since the installation happens with gradle and using Android's gradle set up, don't they already set up the permissions correctly for typical instrumentation tests?
from screenshot-tests-for-android.
@boourns what would the ideal message here be to make it more parseable?
from screenshot-tests-for-android.
This URL is an example of maybe the same bug that is being hit here. The workaround suggested (killing the app) I don't think would work with tests.
@josephmbeveridge could this gradle plugin be changed to install the apk using -g? Would that resolve the issue?
@tdrhq If you wanted to be clever, determine if the app has been built against 23 and is running on 23 to emit an error specifically about this issue, but alternately just mentioning this in a longer error message would be less misleading for people who hit this case. I myself spent a day banging my head against the wall trying to figure it out :)
from screenshot-tests-for-android.
@boourns @tdrhq Yes, changing the plugin to install the apk using -g should fix the permissions issues on api 23 emulators.
from screenshot-tests-for-android.
@boourns Regarding installing with -g, the installation happens from the Android gradle plugin, so I'm surprised they don't already handle this. I imagine this is an issue with all kinds of instrumentation tests.
from screenshot-tests-for-android.
@boourns I'm closing this task since it should be part of the Android Gradle plugin, let me know if there's something actionable on my part. Thanks for the report!
from screenshot-tests-for-android.
To be clear: After PR #29 got merged, setting the compile target to API22 is not sufficient. Your emulator must also be using API level 22 or lower.
@tdrhq Do you know if this was ever fixed in later versions of the Android Gradle Plugin? If it was not fixed, can you file a bug on AndroidStudio and link to the bug from here?
from screenshot-tests-for-android.
Related Issues (20)
- verifyDebugAndroidTestScreenshotTest:RuntimeError HOT 1
- java.lang.OutOfMemoryError: Failed to allocate a 8781536 byte allocation with 4981712 free bytes and 4MB until OOM, max allowed footprint 536870912, growth limit 536870912 at java.util.Arrays.copyOf(Arrays.java:3260) HOT 2
- Library forces arbitrarily small image width HOT 1
- Found 0 Screenshots
- Recording a single test deletes all other screenshots
- Fail to execute runDebugAndroidTestScreenshotTest due to syntax error HOT 1
- Add support to Kotlin DSL
- RunScreenshotTestTask doesn't support configuration cache
- Performance?
- Value error: Operation on closed image when recording/verifying screenshots HOT 2
- Can't record very large view inside ScrollView HOT 4
- Screenshot record fails because of --> "Accessibility content change on non-UI thread"
- Is it possible to hideout dynamic content on the screen before capturing screenshot HOT 1
- Is it possible to vertical scroll and capture full screen
- Incorrect accessibility actions checks in `AccessibilityUtil`
- How to run plugin tests (plugin:check)
- How to install all the artifacts to local maven repository
- plugin id 'com.facebook.testing.screenshot:plugin' version '0.14.0' apply false Fail for android DSL files
- Add SurfaceView support
- test failure: Is your sdcard directory read-only?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from screenshot-tests-for-android.