Coder Social home page Coder Social logo

Comments (8)

tdrhq avatar tdrhq commented on May 5, 2024

what command do you typically use to run your tests? I probably need to make this line customizable: https://github.com/facebook/screenshot-tests-for-android/blob/master/plugin/src/main/groovy/com/facebook/testing/screenshot/build/ScreenshotsPlugin.groovy#L72

from screenshot-tests-for-android.

scompt avatar scompt commented on May 5, 2024

what command do you typically use to run your tests?

connectedAndroidTest

from screenshot-tests-for-android.

tdrhq avatar tdrhq commented on May 5, 2024

ah, looks like I have a bug in https://github.com/facebook/screenshot-tests-for-android/blob/master/plugin/src/main/groovy/com/facebook/testing/screenshot/build/ScreenshotsPlugin.groovy#L17 where I'm reading the property before you get a chance to set it which kind of defeats the purpose. Let me fix this.

from screenshot-tests-for-android.

tdrhq avatar tdrhq commented on May 5, 2024

I landed a fix: 7b3e997

Would you be able to install the jars into a local maven to test this out? If it works, I'll deploy it as a new version early next week (will try to bundle it with other bugs)

from screenshot-tests-for-android.

scompt avatar scompt commented on May 5, 2024

Yep, that fixes it for me. At least it gets me to another error. I'll take a look at that tomorrow.

from screenshot-tests-for-android.

tdrhq avatar tdrhq commented on May 5, 2024

Still having issues? I'm closing this task out for now, but feel free to open another one for the new issues!

from screenshot-tests-for-android.

arpit130 avatar arpit130 commented on May 5, 2024

Please update it the plugin jar on Maven.

from screenshot-tests-for-android.

tdrhq avatar tdrhq commented on May 5, 2024

@arpit130, I have updated the jar on maven central and bumped the version to 0.2.2. Let me know if you find any issues

from screenshot-tests-for-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.