XcodeVersionedName.munki FileMover: [Errno 66] Directory not empty about recipes-for-autopkg

[nmcspadden]

Should be fixed in 50c2311. Please test and let me know.

[macjustice]

Not fixed, here's better verbosity:

FileMover
{'Input': {'source': u'/Users/macj/Library/AutoPkg/Cache/local.munki.XcodeVersionedName/Xcode_unpack/Xcode.app',
           'target': u'/Users/macj/Library/AutoPkg/Cache/local.munki.XcodeVersionedName/Xcode_11.0.0.app'}}
[Errno 66] Directory not empty

I might be misunderstanding how Autopkg does caching, but I think this implies that the PathDeleter processor in XcodeVersionedName.munki.recipe and Xcode.munki.recipe should include the path %RECIPE_CACHE_DIR%/%NAME%_%major_version%.%minor_version%.%patch_version%.app and %RECIPE_CACHE_DIR%/%NAME%.app, respectively.

I can PR if that looks correct to you.

[nmcspadden]

Hmm. I was unable to repro this by running it twice. I'll try again.

[nmcspadden]

Well, I beg your pardon because I apparently can't read. I found the bug in XcodeVersionedName.munki and testing it now.

[nmcspadden]

This should now be actually fixed by b456170. Please test and let me know.

[macjustice]

✅