Comments (3)
from react.
Hey there @PradeepNedun! 👋
I can't access the sandbox you linked to. Did you forget to set it to be publicly viewable?
Thanks! ❤️
from react.
@PradeepNedun I don't see anything wrong here. the memo re-render
log only fires when the dependencies of the useMemo changes (specifically only when the tab
changes, since todos
is created once in the module scope and never updated.
The memo value
log fires any time the TodoList
component renders (including when changing the theme) but that's because you're calling that function in render. So of course, if you call a function in render, then that function is called whenever the component renders.
To fix, you filter the todos and return them from useMemo
directly, instead of returning a function:
const filteredTodos = useMemo(() => {
console.log('memo')
return filterTodos(todos, tab);
}, [todos, tab]);
// ...
filteredTodos.map((todo) => <div> ...</div>);
With this, the expensive filterTodos function will only run when either the todos
or tab
values change.
from react.
Related Issues (20)
- [Compiler Bug]: ref passed as prop cant be mutated in effects/events HOT 2
- [Compiler Todo]: Handle TSSatisfiesExpression expressions HOT 3
- [Compiler Bug]: Runtime error with Higher Order Components HOT 1
- Refs merging/combining HOT 5
- [React 19]
- How to access impure values during render (initially labeled as compiler bug) HOT 2
- Bug(react-hooks/exhaustive-deps): lint rule does not recognise typescript satisfies operator HOT 2
- DevTools Components Hide components filter should hide the component it owns HOT 3
- [React 19] eslint-plugin-react-compiler: “Writing to a variable defined outside a component or hook is not allowed. Consider using an effect” HOT 3
- Bug: eslint-plugin-react-hooks any hook configured in additionalHooks receives warning HOT 5
- [DevTools Bug]: Null destructuring error inspecting a component with `useFormStatus` HOT 1
- [compiler] Combine class component and function component or only class component HOT 3
- ghgh
- [spam]
- [spam]
- [spam]
- [spam]
- Bug: Hydration fails when async script is located outside head tag HOT 6
- [React 19]
- Bug: onSelect does not fire when contentEditable is set to "plaintext-only" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.