on Android，After upgrading React Native from 0.64.2 to 0.72.5, constants returned via getContents in bridge classes cannot be used in JavaScript about react-native

[github-actions]

⚠️	Missing Reproducible Example
ℹ️	We could not detect a reproducible example in your issue report. Please provide either: If your bug is UI related: a Snack If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

[github-actions]

⚠️

Newer Version of React Native is Available!

ℹ️

You are on a supported minor version, but it looks like there's a newer patch available - 0.72.12. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

[cortinico]

What is the question @zwyzzu ?

[zwyzzu]

In the JAVA class (RTNCalculatorTurbo extends NativeRTNCalculatorSpec), the getContents method is overridden to return a map (with map.put("valueStr", "valueString")). In 0.64.2, we were able to reference the constant (RTNCalculator.valueStr) normally, but after upgrading to 0.72.5, using RTNCalculator.valueStr shows undefined

[cortinico]

In the JAVA class (RTNCalculatorTurbo extends NativeRTNCalculatorSpec), the getContents method is overridden to return a map (with map.put("valueStr", "valueString")). In 0.64.2, we were able to reference the constant (RTNCalculator.valueStr) normally, but after upgrading to 0.72.5, using RTNCalculator.valueStr shows undefined

How does your JS file look like for Calculator?
Can you please provide a valid reproducer?

[zwyzzu]

Java

package com.awesomeproject.turbomodule;

import android.util.Log;

import com.autohome.rnmodule.rtncalculator.NativeRTNCalculatorSpec;
import com.awesomeproject.react.RTNCalculatorModuleImpl;
import com.facebook.react.bridge.Promise;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactMethod;

import java.util.HashMap;
import java.util.Map;

public class RTNCalculatorTurbo extends NativeRTNCalculatorSpec {

private static final String TAG = "yedr.RTNCalculatorTurbo";

private ReactApplicationContext reactContext;

private RTNCalculatorModuleImpl impl;

public RTNCalculatorTurbo(ReactApplicationContext reactContext) {
super(reactContext);
this.reactContext = reactContext;
impl = new RTNCalculatorModuleImpl(reactContext);
}

@ReactMethod
public void add(double a, double b, Promise promise) {
// call Delegate
Log.d(TAG, "[newArch]add");
impl.add(a, b, promise);
}

@OverRide
public boolean hasConstants() {
return true;
}

@OverRide
@ReactMethod(isBlockingSynchronousMethod = true)
public Map<String, Object> getConstants() {
final Map<String, Object> map = new HashMap<>();
map.put("valueStr", "valueString");
return map;
}

@OverRide
public void onCatalystInstanceDestroy() {
impl.onCatalystInstanceDestroy();
}

@OverRide
public void initialize() {
impl.initialize();
}

// @OverRide
// public void invalidate() {
// super.invalidate();
// impl.invalidate();
// }
}

JavaScript
import type {TurboModule} from 'react-native/Libraries/TurboModule/RCTExport';
import {TurboModuleRegistry} from 'react-native';

export interface Spec extends TurboModule {
add(a: number, b: number): Promise;
}

export default TurboModuleRegistry.get(
'RTNCalculator',
) as Spec | null;

Using in JavaScript
import RTNCalculator from 'RTNCalculator/js/NativeRTNCalculator.ts'; // TruboModule
console.log('============' + RTNCalculator.valueStr)

[zwyzzu]

By logging, it was found that the getContents method of RTNCalculatorTurbo was not called.

[zwyzzu]

@cortinico help me

[cortinico]

import type {TurboModule} from 'react-native/Libraries/TurboModule/RCTExport'; import {TurboModuleRegistry} from 'react-native';

+export interface SomeConstants {
+   x: string;
+   y: number;
+   z: boolean;
+}

export interface Spec extends TurboModule { 
+   getConstants(): SomeConstants
	add(a: number, b: number): Promise; 
}

export default TurboModuleRegistry.get( 'RTNCalculator', ) as Spec | null;

In order to support Constants with TurboModules, you will have to follow this syntax