Coder Social home page Coder Social logo

Comments (19)

coolzilj avatar coolzilj commented on May 4, 2024

Same problem.
Chrome 35.0.1916.153

from react-devtools.

zpao avatar zpao commented on May 4, 2024

I just tested with a new users and the same version but didn't have that issue. Perhaps OS related?

from react-devtools.

atombender avatar atombender commented on May 4, 2024

OS X here.

from react-devtools.

tsimons avatar tsimons commented on May 4, 2024

Same issue for me. I just reinstalled the extension and the same problem occurs.

OSX Mavericks
Chrome Version 35.0.1916.153

from react-devtools.

palcu avatar palcu commented on May 4, 2024

👍 same problem same versions as @tsimons

from react-devtools.

haohcraft avatar haohcraft commented on May 4, 2024

same problem same version as up

from react-devtools.

yofine avatar yofine commented on May 4, 2024

same problem same version as up

from react-devtools.

jcurtis avatar jcurtis commented on May 4, 2024

Same issue on Chrome Version 36.0.1985.125 on OS X 10.9.4

from react-devtools.

enricribas avatar enricribas commented on May 4, 2024

Same here. Any news guys? Comments say to expose React as global but that doesn't help.

from react-devtools.

zpao avatar zpao commented on May 4, 2024

@enricribas your problem sounds different than this issue, which is that the extension doesn't load at all.

from react-devtools.

zpao avatar zpao commented on May 4, 2024

I have what might be a fix. I can't reproduce though so I have no idea what this will or will not fix. The diff is in #43. I packed the extension and have a crx file if anybody is willing to give it a try: http://cl.ly/WqYL

@enricribas, I may have jumped to conclusions about your case. Sorry!

from react-devtools.

tsimons avatar tsimons commented on May 4, 2024

@zpao I just loaded that extension. The error goes away, but the tools don't load. I get the:

Download the React DevTools for a better development experience: http://fb.me/react-devtools

message in my console from React, and the background page of the extension has no errors.

from react-devtools.

hawkrives avatar hawkrives commented on May 4, 2024

(chrome v. 36.0.1985.125, OS X 10.9.4)

@zpao: I've got the same result as @tsimons. The error goes away, the React devtools don't load, and the DEVTOOLS_INJECTED_SCRIPT key in localStorage is set to function(){console.error("undefined")}.

Edit: But it might just be my app; the test page loads the React tools perfectly.

from react-devtools.

zpao avatar zpao commented on May 4, 2024

If the test page and the React website work, then I'm going to blame your app. Make sure you export React to the window, as mentioned in the readme. If you can inspect anything, I think this fix is fine. Let me know!

from react-devtools.

tsimons avatar tsimons commented on May 4, 2024

Exposing react to window worked for me. Thanks for pointing that out.

Would it be possible to modify the script that logs the "download devtools" message to also check for window.React?

from react-devtools.

hawkrives avatar hawkrives commented on May 4, 2024

Yeah, it now works for me, too.

The only thing is, I was already explicitly exposing window.React, but I'll just chalk it up to one of those oddities in computers.

Thanks, guys.

from react-devtools.

atombender avatar atombender commented on May 4, 2024

Works for me, too, even without the fix from @zpao.

from react-devtools.

zpao avatar zpao commented on May 4, 2024

Thanks for testing! I'll get the fix merged in and make sure we push out an update.

Would it be possible to modify the script that logs the "download devtools" message to also check for window.React?

We're (slowly) working on better solution there. Simply checking for window.React isn't enough and actually wouldn't work at the point we log that message.

from react-devtools.

tsimons avatar tsimons commented on May 4, 2024

Yeah I realized that after I had submit... haha.

I also noticed one thing that related to some confusion here, and this is probably due to my lack of chrome extension knowledge. The script that loads the extension in the chrome inspector panel only runs when you first visit a site. For instance, I added window.React = React to my app, then refreshed my currently open page and nothing happened. When I opened a new tab and visited my app again, the react tab appeared. Hopefully this clears up some confusion for someone else!

from react-devtools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.