Comments (3)
@wjhrdy This is a good point. It was definitely a result of our internal use-cases. I'll add this name change to the 0.2 release milestone and we'll work on making it backward compatible by accepting both.
Nice job on your package! If I had known about it we would have used it!
from prophet.
@seanjtaylor I'd favor leaving this as holidays
in the code, and just updating the documentation to describe that this component is for 'holidays and other recurring events', or something along those lines. I certainly agree that events
would have been a more appropriate choice, but maintaining support for both just seems like a pain. I'm guessing the typical usage for this feature is actual holidays, and people with non-holiday events would be able to tell from the documentation that this is the right interface. We also now have the add_regressor
method which provides a more general interface, with a more general name.
from prophet.
I think with the add_regressor
method there is now the more generally-termed interface for handling these types of things, and since it would be a pretty big disruption to remove/rename the holidays argument, I'm going to go ahead and not make this change unless anyone has any further objections.
from prophet.
Related Issues (20)
- Cannot install package sentence_trasnformers
- New to Prophet HOT 3
- Not getting what I expect from a Cross Validation using monthly data and cutoffs
- prophet.serialize FutureWarning: The behavior of Timestamp.utcfromtimestamp is deprecated...
- Seeking clarification on setting custom holiday prior scale HOT 2
- Schedule retrain an existing prophet model HOT 6
- New Forecasts on existing data different than original forecast.
- Problem with turtle andy pygame
- python: can't open file '/home/chris/cupp.py': [Errno 2] No such file or directory
- cant install fbprophet using pip install fbprophet HOT 2
- change cost function to Sum of square error
- Numpy dependency version needs to be bumped to 1.20.x for numpy.typing
- Weekend predictions and holidays on high frequency daily data
- I have a issue in installation of prophet library HOT 2
- error in pip install pystan, cython was installed, does anyone know how to solve it?
- Fit params for kwargs
- fbprophet installing error HOT 1
- RuntimeError: Error during optimization: console log output: dyld[10867]: Symbol not found
- pip install guardrails getting this error HOT 2
- Prophet Training Speed: Intel vs Apple M1/M2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prophet.