Comments (4)
I've got a WIP fix for this: metavida/PathPicker@master...include_git_status_dotfiles
from pathpicker.
I believe dot files inside directory are not a problem.
So the issue is actualy about dot files and with not period in the current directory. Do you confirm? It seems that those are not detected by design since it's more likely that they are not paths in the input.
from pathpicker.
This is a duplicate of #7.
from pathpicker.
Thanks for checking out this ticket @pedrox. First, I'd like to make a clarification. When I say "dotfile" I mean "any file that begins with a period"[1].
I believe dot files inside directory are not a problem.
I confirmed that PathPicker does not recognize dotfiles within a directory by adding the following case to test.py
on the latest master branch commit.
{
'input': 'tmp/.gitignore',
'match': True,
'file': 'tmp/.gitignore',
'num': 0
}
$ git log -n1 | head -n1
commit 7b0bef202b9f4783197459e26fe658f404b99188
$ python src/test.py
...
======================================================================
FAIL: testFileMatch (__main__.TestParseFunction)
----------------------------------------------------------------------
Traceback (most recent call last):
File "src/test.py", line 244, in testFileMatch
self.checkFileResult(testCase)
File "src/test.py", line 252, in checkFileResult
testCase['input'])
AssertionError: Line "tmp/.gitignore" did not match any regex
----------------------------------------------------------------------
Ran 5 tests in 0.007s
FAILED (failures=2, errors=1)
This is a duplicate of #7.
To my reading, issue #7 is about detecting files with no extensions (e.g. Makefile
). While this issue is similar, I would suggest that this ticket is not a duplicate of #7 because it's quite possible to have a dotfile with an extension (e.g. .env.production
or .hidden.txt
).
from pathpicker.
Related Issues (20)
- Allow configuring keyboard controls
- Command mode is broken in latest master HOT 1
- fpp-git on AUR is quite outdated HOT 2
- Feature Request: Make man page easier to read, put each flag in its own line. HOT 5
- Filename within `#` cannot be pick
- The way of determining shell is not reliable.
- Demo videos in homepage not loading on mobile HOT 2
- Issue and PR templates HOT 2
- Skip the `F` key in quick select mode
- Problems with paths with spaces in them
- New release before EOY? HOT 6
- Support for git diffs
- Standalone Executable File
- fpp not opening files in $EDITOR HOT 7
- Infinite loop when selecting entry with certain width relative to window width HOT 1
- Release 0.9.5 but fpp --version says 0.9.2 HOT 1
- feature request: open files in vim tab pages
- chore: use pre-commit hook
- ci: update versions and add `paths-ignore`
- macOS Python segfault HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pathpicker.