Comments (3)
Hey @sandyarmstrong
I can't seem to reproduce this -- we definitely allow multiple periods in the filename:
Can you perhaps provide some example input or a solid repro?
Note that we have separate regex for files that dont have a directory prepended to them (aka stuff like echo.py
):
https://github.com/facebook/PathPicker/blob/master/src/parse.py#L30
but we have to be a lot more restrictive with that regex since we dont want to match JS code like:
data.object.some.field
(closing for now, reopen if you have the repro). a lot of this pain would go away if we simply checked if the file exists...
from pathpicker.
Your example only works because you provided an absolute path. It fails with relative paths. For example:
touch ~/banana.Project.sln
cd ~
echo banana.Project.sln | fpp
ls | fpp
Then you'll see the bad matching. I've tested with latest master.
from pathpicker.
Fixed in 3792357.
from pathpicker.
Related Issues (20)
- Allow configuring keyboard controls
- Command mode is broken in latest master HOT 1
- fpp-git on AUR is quite outdated HOT 2
- Feature Request: Make man page easier to read, put each flag in its own line. HOT 5
- Filename within `#` cannot be pick
- The way of determining shell is not reliable.
- Demo videos in homepage not loading on mobile HOT 2
- Issue and PR templates HOT 2
- Skip the `F` key in quick select mode
- Problems with paths with spaces in them
- New release before EOY? HOT 6
- Support for git diffs
- Standalone Executable File
- fpp not opening files in $EDITOR HOT 7
- Infinite loop when selecting entry with certain width relative to window width HOT 1
- Release 0.9.5 but fpp --version says 0.9.2 HOT 1
- feature request: open files in vim tab pages
- chore: use pre-commit hook
- ci: update versions and add `paths-ignore`
- macOS Python segfault HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pathpicker.