Comments (2)
Ideally, board specific changes are in meta-openbmc/meta-company/meta-board. It is achievable but adding difficulty for development and maintenance, specially, in u-boot and kernel. Both u-boot and kernel already have great mechanism to support different boards/HWs. We would like leverage such mechanism, which means, HW/boards specific changes will be in SoC layer.
u-boot has board layers, currently, we re-used the ast2400 board layer for wedge development. That won't work for different boards. We will need to create separate directory for each different boards.
In kernel, we created separate configuration for wedge, wedge_defconfig. Then, use '#ifdef CONFIG_WEDGE' for wedge specific changes. However, we want to limit usage of '#ifdef' in source code. For example, for the code to enable/disable LPC, I would prefer to having a macro like CONFIG_ASPEED_ENABLE_LPC used in the source code, then each different HW defconfig has that macro defined or not depending on board specific design.
from openbmc.
Sounds good, I'll get you some changes that adhere to the concepts. Employing the _defconfig more fits with our thoughts too
from openbmc.
Related Issues (20)
- The return value of 'sscanf()' should be checked
- Removal of `yocto_repos.sh` breaks `sync_yocto.sh` script HOT 3
- Fetcher failure HOT 1
- Support aspeed 2600 HOT 3
- no limitation for "%s" while calling fscanf()
- Yocto Build time improvements? HOT 1
- Docs on ast2600 boot procedure HOT 3
- License Missing
- AST2600 Support HOT 2
- Eth0 fix missing for meta-fbtp build on Portwell Neptune Board HOT 1
- Unable to set hostname through DHCP HOT 1
- Redfish supportive HOT 1
- GitHub Actions Experiments HOT 1
- Is there any support for ast2600 HOT 1
- Flashy will break on AST2600 HOT 6
- flashy: Golang status (Note to self) HOT 2
- Fboss and compute platform HOT 1
- openbmc-init-build-env error HOT 1
- flash image HOT 2
- Redfish: Https authentication
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openbmc.